Issue metadata
Sign in to add a comment
|
css outline glitchy with display: table
Reported by
huglovef...@gmail.com,
Feb 1 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36 Example URL: Steps to reproduce the problem: 1. open the attached test page 2. hover the links "post1" and "post2" - outlines should appear on other elements 3. check the "display: table" checkbox 4. hover the links again What is the expected behavior? hovering the links should make the outlines appear normally again What went wrong? parts of the outline are missing or fail to disappear when they should, or the outlines don't appear at all (try clicking the links if this happens) Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes 64.0.3281.0 Does this work in other browsers? Yes Chrome version: 64.0.3282.119 Channel: stable OS Version: Flash Version: also happens on windows, and with hardware acceleration disabled bisect-builds.py: You are probably looking for a change made after 520307 (known good), but no later than 520314 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/e3f8933fd527d9efae3a5ab1641a2da2688e3bfa..95207faf41bf63b1ae5683cd24127515a84ee2d2 this commit looks related: https://chromium.googlesource.com/chromium/src/+/4cabfbfd5efa0557b64692c1ab10047b1eaec9b5
,
Feb 1 2018
,
Feb 2 2018
Able to reproduce the issue on Windows 10, mac 10.12.6 and Ubuntu 14.04 using chrome reported version #64.0.3282.119 and latest canary #66.0.3336.0. Bisect Information: ===================== Good build: 64.0.3280.0 Bad Build : 64.0.3281.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/e3f8933fd527d9efae3a5ab1641a2da2688e3bfa..4cabfbfd5efa0557b64692c1ab10047b1eaec9b5 From the above change log suspecting below change Change-Id: Ic83e6f74ff87b6baea6b1cf68d1cd9d841b8080e Reviewed-on: https://chromium-review.googlesource.com/777845 chrishtr@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Adding stable blocker for M-64 as it seems to be a recent regression. Please feel free to remove the same if not appropriate. Thanks...!!
,
Feb 2 2018
Looking now.
,
Feb 2 2018
I have a simple fix, writing up CL now.
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc976225e037d9f9ed5cf135bcd16a1187a30d42 commit bc976225e037d9f9ed5cf135bcd16a1187a30d42 Author: Chris Harrelson <chrishtr@chromium.org> Date: Fri Feb 02 22:41:31 2018 [PE] Recompute overflow for tables A previous refactor accidentally omitted delegation to the parent class when recomputing overflow for LayoutTable. Bug:807900 Change-Id: I68c415de59162a29b642ad697e7b8ab8dc19f530 Reviewed-on: https://chromium-review.googlesource.com/900044 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534175} [modify] https://crrev.com/bc976225e037d9f9ed5cf135bcd16a1187a30d42/third_party/WebKit/Source/core/layout/LayoutTable.cpp [modify] https://crrev.com/bc976225e037d9f9ed5cf135bcd16a1187a30d42/third_party/WebKit/Source/core/layout/LayoutTableTest.cpp
,
Feb 2 2018
,
Feb 2 2018
,
Feb 3 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 4 2018
Pls merge your change to M65 branch 3325 before 2:00 PM PT tomorrow, Monday (02/25/18) so we can pick it up for last dev release on Tuesday. Thank you.
,
Feb 5 2018
ClusterFuzz found a problem with this change in issue 808876
,
Feb 5 2018
Just to confirm, this should be okay to wait until M65 correct? I am removing this as a stable blocker for M64.
,
Feb 5 2018
Yes it's ok to wait for 65.
,
Feb 5 2018
changing back "Merge-Request-65" per offline chat with chrishtr@, this is not ready to merge yet. Please update the bug once ready. Thank you.
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dd7c6ae3b1ec83b34931cfcb05a60d4a86e103c commit 0dd7c6ae3b1ec83b34931cfcb05a60d4a86e103c Author: Chris Harrelson <chrishtr@chromium.org> Date: Mon Feb 05 22:29:24 2018 Revert "[PE] Recompute overflow for tables" This reverts commit bc976225e037d9f9ed5cf135bcd16a1187a30d42. Reason for revert: <INSERT REASONING HERE> Original change's description: > [PE] Recompute overflow for tables > > A previous refactor accidentally omitted delegation to the > parent class when recomputing overflow for LayoutTable. > > Bug:807900 > > Change-Id: I68c415de59162a29b642ad697e7b8ab8dc19f530 > Reviewed-on: https://chromium-review.googlesource.com/900044 > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534175} TBR=chrishtr@chromium.org,schenney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 807900 , 808876 Change-Id: I9a0b6ca4dd8ae3d80990b754b997aa9cd4beb0c5 Reviewed-on: https://chromium-review.googlesource.com/902502 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#534510} [modify] https://crrev.com/0dd7c6ae3b1ec83b34931cfcb05a60d4a86e103c/third_party/WebKit/Source/core/layout/LayoutTable.cpp [modify] https://crrev.com/0dd7c6ae3b1ec83b34931cfcb05a60d4a86e103c/third_party/WebKit/Source/core/layout/LayoutTableTest.cpp
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/242dbc9f7b63cd54f90d3559cc08040198f7a9c8 commit 242dbc9f7b63cd54f90d3559cc08040198f7a9c8 Author: Chris Harrelson <chrishtr@chromium.org> Date: Tue Feb 06 20:37:40 2018 [PE] Re-land: Recompute overflow for tables This is a re-land of commit bc976225e037d9f9ed5cf135bcd16a1187a30d42, which had a type-casting bug due to failure to override child overflow recursion. The new patch also includes a test adjustment and DCHECK to avoid such security bugs. Bug: 807900 , 808876 Change-Id: I9210cf48b25ca255ceccd955fd4699e76620f90f Reviewed-on: https://chromium-review.googlesource.com/902763 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534785} [modify] https://crrev.com/242dbc9f7b63cd54f90d3559cc08040198f7a9c8/third_party/WebKit/Source/core/layout/LayoutBlock.cpp [modify] https://crrev.com/242dbc9f7b63cd54f90d3559cc08040198f7a9c8/third_party/WebKit/Source/core/layout/LayoutBlock.h [modify] https://crrev.com/242dbc9f7b63cd54f90d3559cc08040198f7a9c8/third_party/WebKit/Source/core/layout/LayoutTable.cpp [modify] https://crrev.com/242dbc9f7b63cd54f90d3559cc08040198f7a9c8/third_party/WebKit/Source/core/layout/LayoutTableTest.cpp
,
Feb 7 2018
Requesting merge of commit in comment 16 to 65. My re-land fixed the security issue.
,
Feb 7 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 7 2018
Is CL listed at #16 overall safe to merge to M65 now?
,
Feb 7 2018
Yes I think it's pretty safe. clusterfuzz would have complained by now if there was a remaining type conversion bug. I can wait one more day before actually merging to be extra sure there are no other issues.
,
Feb 7 2018
Sure, pls update the bug tomorrow with canary result.
,
Feb 8 2018
The NextAction date has arrived: 2018-02-08
,
Feb 8 2018
All seems good, no problems reported. Merge today?
,
Feb 8 2018
Approving merge to M65 branch 3325 based on comment #23. Pls merge today. Thank you.
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2179fe0f9290d36b73ffc46f4e57ba665acbc880 commit 2179fe0f9290d36b73ffc46f4e57ba665acbc880 Author: Chris Harrelson <chrishtr@chromium.org> Date: Thu Feb 08 23:20:40 2018 [PE] Re-land: Recompute overflow for tables This is a re-land of commit bc976225e037d9f9ed5cf135bcd16a1187a30d42, which had a type-casting bug due to failure to override child overflow recursion. The new patch also includes a test adjustment and DCHECK to avoid such security bugs. TBR=chrishtr@chromium.org (cherry picked from commit 242dbc9f7b63cd54f90d3559cc08040198f7a9c8) Bug: 807900 , 808876 Change-Id: I9210cf48b25ca255ceccd955fd4699e76620f90f Reviewed-on: https://chromium-review.googlesource.com/902763 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#534785} Reviewed-on: https://chromium-review.googlesource.com/910093 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#395} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/2179fe0f9290d36b73ffc46f4e57ba665acbc880/third_party/WebKit/Source/core/layout/LayoutBlock.cpp [modify] https://crrev.com/2179fe0f9290d36b73ffc46f4e57ba665acbc880/third_party/WebKit/Source/core/layout/LayoutBlock.h [modify] https://crrev.com/2179fe0f9290d36b73ffc46f4e57ba665acbc880/third_party/WebKit/Source/core/layout/LayoutTable.cpp [modify] https://crrev.com/2179fe0f9290d36b73ffc46f4e57ba665acbc880/third_party/WebKit/Source/core/layout/LayoutTableTest.cpp
,
Feb 8 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kochi@chromium.org
, Feb 1 2018