powerd: Make it possible for board to define particular input devices as internal |
||
Issue descriptionThe tags described in this doc: https://chromium.googlesource.com/chromiumos/platform2/+/master/power_manager/docs/udev.md are set using a bunch of udev rules (https://chromium.googlesource.com/chromiumos/platform2/+/master/power_manager/udev/): - 90-powerd-id.rules: Sets internal/external_touchpad/screen/keyboard POWER_ROLE tag: SUBSYSTEM=="input", ENV{ID_INPUT_KEYBOARD}=="1", DRIVERS=="atkbd", ENV{POWERD_ROLE}="internal_keyboard" - 91-powerd-tags.rules ENV{POWERD_ROLE}=="internal_keyboard", ENV{POWERD_TAGS_USABLE}="usable_when_laptop usable_when_display_off" - 93-powerd-late.rules (does other things) We would like to specify some specific devices to be internal (say "internal_keyboard"), so we need a new rule between 90-powerd-id.rules and 91-powerd-tags.rules to override the default decision made by 90-powerd-id.rules. New rules order: - 90-powerd-id.rules - 91: Custom per-board overrides - 92-powerd-tags.rules - 93: Custom per-board powerd overrides (overlay-kevin uses this) - 94-powerd-late.rules
,
Feb 1 2018
I checked a few devices and didn't see any other rules that could be messed up by this, so it seems okay to me.
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/78f7ef2660be2d427866dee8e86ed6e59d4b9040 commit 78f7ef2660be2d427866dee8e86ed6e59d4b9040 Author: Nicolas Boichat <drinkcat@google.com> Date: Fri Feb 02 15:03:03 2018 kevin: Renumber 92-powerd-overrides.rules to 93 We are adding more space between powerd rules 90 and 91. CQ-DEPEND=CL:896729 BUG= chromium:807889 TEST=N/A Change-Id: Icbfba0b497649a5e0f2f05fb640fbcf4775cccbd Reviewed-on: https://chromium-review.googlesource.com/896726 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Benson Leung <bleung@chromium.org> [modify] https://crrev.com/78f7ef2660be2d427866dee8e86ed6e59d4b9040/overlay-kevin/chromeos-base/chromeos-bsp-kevin/chromeos-bsp-kevin-0.0.3.ebuild [rename] https://crrev.com/78f7ef2660be2d427866dee8e86ed6e59d4b9040/overlay-kevin/chromeos-base/chromeos-bsp-kevin/chromeos-bsp-kevin-0.0.3-r12.ebuild [rename] https://crrev.com/78f7ef2660be2d427866dee8e86ed6e59d4b9040/overlay-kevin/chromeos-base/chromeos-bsp-kevin/files/93-powerd-overrides.rules
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c2a8189489131dbadb03f768b338d48af7bd78a1 commit c2a8189489131dbadb03f768b338d48af7bd78a1 Author: Nicolas Boichat <drinkcat@google.com> Date: Fri Feb 02 15:03:05 2018 chromeos-base/power_manager: Renumber 92- udev rules to 93- We are adding more space between powerd rules 90 and 91 for overrides. CQ-DEPEND=CL:896729 BUG= chromium:807889 TEST=tryjob on soraka Change-Id: I361fc84d3955bef827302beebb2b049856166f88 Reviewed-on: https://chromium-review.googlesource.com/896730 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Benson Leung <bleung@chromium.org> [modify] https://crrev.com/c2a8189489131dbadb03f768b338d48af7bd78a1/chromeos-base/power_manager/power_manager-9999.ebuild
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b46788bcb1894c40e327dd4f5f0816c9087c71d8 commit b46788bcb1894c40e327dd4f5f0816c9087c71d8 Author: Nicolas Boichat <drinkcat@google.com> Date: Fri Feb 02 15:03:06 2018 power: Renumber 92-powerd-overrides.rules to 93 We are adding more space between powerd rules 90 and 91 for overrides. CQ-DEPEND=CL:896726 CQ-DEPEND=CL:896730 BUG= chromium:807889 TEST=tryjob on soraka Change-Id: I361fc84d3955bef827302beebb2b049856166f88 Reviewed-on: https://chromium-review.googlesource.com/896729 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> [rename] https://crrev.com/b46788bcb1894c40e327dd4f5f0816c9087c71d8/power_manager/udev/optional/93-powerd-tags-touchscreen-wakeup.rules [modify] https://crrev.com/b46788bcb1894c40e327dd4f5f0816c9087c71d8/power_manager/docs/udev.md [rename] https://crrev.com/b46788bcb1894c40e327dd4f5f0816c9087c71d8/power_manager/udev/optional/93-powerd-tags-keyboard-side-buttons.rules [rename] https://crrev.com/b46788bcb1894c40e327dd4f5f0816c9087c71d8/power_manager/udev/92-powerd-tags.rules [rename] https://crrev.com/b46788bcb1894c40e327dd4f5f0816c9087c71d8/power_manager/udev/optional/93-powerd-tags-no-touchpad-wakeup.rules [rename] https://crrev.com/b46788bcb1894c40e327dd4f5f0816c9087c71d8/power_manager/udev/94-powerd-late.rules [modify] https://crrev.com/b46788bcb1894c40e327dd4f5f0816c9087c71d8/power_manager/powerd/system/udev.h
,
Feb 3 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by drinkcat@chromium.org
, Feb 1 2018