Make sure all dialogs invocable from browser_tests have proper titlecasing for buttons and titles on Mac. |
|
Issue descriptionThanks to tapted@'s code this is feasible. Assigning this to myself to track.
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18e528eb278e883644ce99c0ab7cce2e11eb8740 commit 18e528eb278e883644ce99c0ab7cce2e11eb8740 Author: Peter Boström <pbos@chromium.org> Date: Fri Feb 02 01:54:09 2018 Add missing titlecase for dialog-danger bubble. Bug: chromium:807886 Change-Id: I1eb8ed1c1ddd6e07ba38f63f66a140a0a524c356 Reviewed-on: https://chromium-review.googlesource.com/898523 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#533911} [modify] https://crrev.com/18e528eb278e883644ce99c0ab7cce2e11eb8740/chrome/app/generated_resources.grd
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4af20f07ce09da167dd5631e095483514b5e588b commit 4af20f07ce09da167dd5631e095483514b5e588b Author: Peter Boström <pbos@chromium.org> Date: Fri Feb 02 16:02:29 2018 Add missing titlecase for autofill. Conditional titlecase is required for Mac dialogs. Bug: chromium:807886 Change-Id: I0edc79ef9485d1cca541e4c309eb6360d8169109 Reviewed-on: https://chromium-review.googlesource.com/898428 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#534063} [modify] https://crrev.com/4af20f07ce09da167dd5631e095483514b5e588b/components/autofill_strings.grdp
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4ee33c7fd02ac9ac80a7009a1be2ace1ac9f330 commit b4ee33c7fd02ac9ac80a7009a1be2ace1ac9f330 Author: Peter Boström <pbos@chromium.org> Date: Sat Feb 03 00:50:08 2018 Add titlecase to extension-installed bubble. Also removes a stale promo string that has been replaced. Bug: chromium:807886 Change-Id: I63d64ec65573eb2742fcb59cea790a720fae0a41 Reviewed-on: https://chromium-review.googlesource.com/900053 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#534217} [modify] https://crrev.com/b4ee33c7fd02ac9ac80a7009a1be2ace1ac9f330/chrome/app/chromium_strings.grd [modify] https://crrev.com/b4ee33c7fd02ac9ac80a7009a1be2ace1ac9f330/chrome/app/generated_resources.grd [modify] https://crrev.com/b4ee33c7fd02ac9ac80a7009a1be2ace1ac9f330/chrome/app/google_chrome_strings.grd
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1801b02004f2380fc77b2f787748c026ba170048 commit 1801b02004f2380fc77b2f787748c026ba170048 Author: Peter Boström <pbos@chromium.org> Date: Sat Feb 03 00:50:13 2018 Add titlecase to global-error bubble. Bug: chromium:807886 Change-Id: I1050d89178fb6682cafa3a03327a9c1245203b26 Reviewed-on: https://chromium-review.googlesource.com/900064 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#534218} [modify] https://crrev.com/1801b02004f2380fc77b2f787748c026ba170048/chrome/app/generated_resources.grd
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7b3d294eaac9aa0953434500661aa8587eec959 commit e7b3d294eaac9aa0953434500661aa8587eec959 Author: Peter Boström <pbos@chromium.org> Date: Mon Feb 05 22:24:56 2018 Add titlecase to the permission dialog. Bug: chromium:807886 Change-Id: Ib4ae5e020aa02ad08f038f1827475353fa747ff0 Reviewed-on: https://chromium-review.googlesource.com/902437 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#534507} [modify] https://crrev.com/e7b3d294eaac9aa0953434500661aa8587eec959/chrome/app/generated_resources.grd
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/200620648d0c09e472eb3a41378ee2ce26bf693e commit 200620648d0c09e472eb3a41378ee2ce26bf693e Author: Peter Boström <pbos@chromium.org> Date: Tue Feb 06 00:54:03 2018 Add missing titlecase for device-chooser titles. Adds use_titlecase entries for USB device selection, Bluetooth pairing and device permissions. Bug: chromium:807886 Change-Id: I355d944e151c14967998d283d5ad578ba512ae9d Reviewed-on: https://chromium-review.googlesource.com/898246 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#534561} [modify] https://crrev.com/200620648d0c09e472eb3a41378ee2ce26bf693e/chrome/app/generated_resources.grd [modify] https://crrev.com/200620648d0c09e472eb3a41378ee2ce26bf693e/extensions/strings/extensions_strings.grd
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4198089db7d1923cc83f6e24677131bb11bfefd7 commit 4198089db7d1923cc83f6e24677131bb11bfefd7 Author: Peter Boström <pbos@chromium.org> Date: Tue Feb 06 01:31:42 2018 Add titlecase to the sign-in-confirmation dialog. Bug: chromium:807886 Change-Id: I2f5cad8e023c8a6f7e27a29a8579c0a5070754c7 Reviewed-on: https://chromium-review.googlesource.com/902562 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#534572} [modify] https://crrev.com/4198089db7d1923cc83f6e24677131bb11bfefd7/chrome/app/chromium_strings.grd [modify] https://crrev.com/4198089db7d1923cc83f6e24677131bb11bfefd7/chrome/app/generated_resources.grd [modify] https://crrev.com/4198089db7d1923cc83f6e24677131bb11bfefd7/chrome/app/google_chrome_strings.grd
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ff7924d15013c3b0250644306273f5fad81586d commit 3ff7924d15013c3b0250644306273f5fad81586d Author: Peter Boström <pbos@chromium.org> Date: Tue Feb 06 10:48:08 2018 Add titlecase to the autofill save-card dialog. Bug: chromium:807886 Change-Id: I5bc1a654954d65b527e297a27ae7d3417e97b3e6 Reviewed-on: https://chromium-review.googlesource.com/902799 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#534674} [modify] https://crrev.com/3ff7924d15013c3b0250644306273f5fad81586d/components/autofill_strings.grdp
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40381082a700e5615c75746e186f2bb9f66ed641 commit 40381082a700e5615c75746e186f2bb9f66ed641 Author: Peter Boström <pbos@chromium.org> Date: Tue Feb 06 17:41:33 2018 Add branded titlecase for global-error bubble. These strings were missed as they were not in generated_resources.grd. Bug: chromium:807886 Change-Id: I3c0c812f751487fffa6dc167cff21e0af269bf73 Reviewed-on: https://chromium-review.googlesource.com/902187 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#534707} [modify] https://crrev.com/40381082a700e5615c75746e186f2bb9f66ed641/chrome/app/chromium_strings.grd [modify] https://crrev.com/40381082a700e5615c75746e186f2bb9f66ed641/chrome/app/generated_resources.grd [modify] https://crrev.com/40381082a700e5615c75746e186f2bb9f66ed641/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/40381082a700e5615c75746e186f2bb9f66ed641/chrome/browser/recovery/recovery_install_global_error.cc
,
Feb 7 2018
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9899f618e385275abce26fa0988bbb801bff146 commit a9899f618e385275abce26fa0988bbb801bff146 Author: Peter Boström <pbos@chromium.org> Date: Wed Feb 14 00:01:21 2018 Revert "Add missing titlecase for device-chooser titles." This reverts commit 200620648d0c09e472eb3a41378ee2ce26bf693e. Reason for revert: Titlecasing bubble titles is no longer relevant. Original change's description: > Add missing titlecase for device-chooser titles. > > Adds use_titlecase entries for USB device selection, Bluetooth pairing > and device permissions. > > Bug: chromium:807886 > Change-Id: I355d944e151c14967998d283d5ad578ba512ae9d > Reviewed-on: https://chromium-review.googlesource.com/898246 > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Commit-Queue: Peter Boström <pbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534561} TBR=lazyboy@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:807886 , chromium:810111 Change-Id: Ib23cdfc01cedd382785c0e111faaac2507b1b95e Reviewed-on: https://chromium-review.googlesource.com/917341 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#536560} [modify] https://crrev.com/a9899f618e385275abce26fa0988bbb801bff146/chrome/app/generated_resources.grd [modify] https://crrev.com/a9899f618e385275abce26fa0988bbb801bff146/extensions/strings/extensions_strings.grd |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Feb 2 2018