New issue
Advanced search Search tips

Issue 807885 link

Starred by 1 user
Status: Fixed
Owner:
btolsch@chromium.org
Closed: Apr 2018
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Page info dialog doesn't display for PresentationReceiverWindowController

Project Member Reported by btolsch@chromium.org, Feb 1 2018 
Chrome Version       : 66.0.3332.0

Steps to reproduce:
1. Start a presentation with more than one display connected (e.g. via https://googlechrome.github.io/samples/presentation-api/)
2. Take the presentation window out of fullscreen (F11 on platforms besides Mac).
3. Click the security chip in the location bar.

Expected result:
Page info dialog shown with content setting information like cookies used, notification settings, etc.

Actual result:
Nothing is shown.

ShowPageInfoDialog() is responsible for creating the dialog and it looks for a Browser object associated with the active WebContents.  This seems to be used for the Profile, the LocationIconView, the top level gfx::NativeWindow, and the LocationBarView's security bubble anchor view.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4901a12bb32cd65e8c141cf97339a5a604c3dfd

commit c4901a12bb32cd65e8c141cf97339a5a604c3dfd
Author: btolsch <btolsch@chromium.org>
Date: Tue Apr 03 05:49:21 2018

Fix page info dialog for PresentationReceiverWindowController

The page info dialog shows information about the content settings and
preferences set for the page shown by a given WebContents.  This
includes security information, cookies in use, etc.  The implementation
that shows it relies on the WebContents being contained in a Browser
object.  PresentationReceiverWindow introduced a scenario where we want
to show the page info dialog but don't have a Browser object.

This change adds a method for LocationBar to be called to show the page
info dialog directly so it can be called from the presentation receiver
window.

Bug:  807885 
Change-Id: I9981ab04e0982c5d01ed11e83437714e9d8e90b2
Reviewed-on: https://chromium-review.googlesource.com/924473
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547628}
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/location_bar/location_bar.h
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/views/media_router/presentation_receiver_window_view_browsertest.cc
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/browser/ui/views/page_info/page_info_bubble_view.h
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/test/BUILD.gn
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/test/base/test_browser_window.cc
[modify] https://crrev.com/c4901a12bb32cd65e8c141cf97339a5a604c3dfd/chrome/test/base/test_browser_window.h

Comment 2 by btolsch@chromium.org, Apr 4 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment