New Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-csstransformcomponent-tomatrix We added a toMatrix() method on CSSTransformComponent. Implementation should be easy, we already do this in [1] (just have to rename it). Tests already exist as well [2]. Tests all use to be part of CSSTransformValue, but now they can be split into their individual files based on the subclass. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h?q=CSSTransform&sq=package:chromium&l=49
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ef5e5a586e89c50459c19b7448b4fa20da47cbb commit 8ef5e5a586e89c50459c19b7448b4fa20da47cbb Author: Darren Shen <shend@chromium.org> Date: Mon Feb 12 02:02:18 2018 [css-typed-om] Implement CSSTransformComponent.toMatrix(). This patch implements CSSTransformComponent.toMatrix(), which was previously implemented as AsMatrix() but just not webexposed. We also split up the tests since it makes more sense. Bug: 807877 Change-Id: Icee742fdde033d63cea85a27250e91a71ad67e2a Reviewed-on: https://chromium-review.googlesource.com/910529 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#536022} [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/interfaces-expected.txt [add] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-toMatrix-relative-units.html [add] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-toMatrix.html [add] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssTransformValue-toMatrix.html [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssTransformValue.tentative.html [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.cpp [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSPerspective.cpp [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSPerspective.h [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSRotate.cpp [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSRotate.h [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSScale.cpp [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSScale.h [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSSkew.h [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSSkewX.cpp [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSSkewX.h [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSSkewY.cpp [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSSkewY.h [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.idl [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSTranslate.cpp [modify] https://crrev.com/8ef5e5a586e89c50459c19b7448b4fa20da47cbb/third_party/WebKit/Source/core/css/cssom/CSSTranslate.h
Comment 1 by shend@chromium.org
, Feb 6 2018Status: Assigned (was: Available)