New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807856 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ext4 migration 100% failing since R65-10302.0.0

Project Member Reported by kinaba@chromium.org, Feb 1 2018

Issue description

Chrome Version: 66.0.3329.0
OS: R66-10361.0.0

Judging from the UMA stats, R65-10302.0.0 (65.0.3319.0) was the first bad dev push while R65-10278.0.0 (65.0.3299.0) was good.


What steps will reproduce the problem?
(1) Prepare an user account with ecryptfs filesystem (sign-in using R57 Chrome OS and then upgrade to latest dev/canary version, or $ cryptohome --action=mount_ex --create --ecryptfs --key_label=foo --user=<yourtestaccount@gmail.com> from shell and restart)
(2) Try signing into the account.
(3) ext4 migration wizard ("Install OS Update") should come up. click the [Update] button

What is the expected result?
Migration begins

What happens instead?
Error ("something went wrong")
 
Summary: ext4 migration 100% failing since R65-10302.0.0 (was: ext4 migration 100% failing since R65-10278.0.0)
Filed  Bug 807876  for adding tests that prevents this kind of accidents in the future.

# I put it into a separate bug/CL because I want to keep the fixing CL minimal, so that it can very safely merged to the beta branch as soon as possible.
Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41978a3923e22c69057a0910200b691d77c085a3

commit 41978a3923e22c69057a0910200b691d77c085a3
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Thu Feb 01 05:57:35 2018

ext4-migration: Mount with the correct authorization info when starting migration.

The info was lost during a refactoring: 7803fe02870ac7833a30d3c71b15fe0aea159db

BUG= 807856 
TEST=manually try the migration

Change-Id: I5e986b53f099ce3c7c28bbb66fabf6eb7263521d
Reviewed-on: https://chromium-review.googlesource.com/897066
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533580}
[modify] https://crrev.com/41978a3923e22c69057a0910200b691d77c085a3/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc

Labels: Merge-Request-65
At least chromium.chromiumos builds passed. Requesting the merge to M65. +Bernie

(In case if the beta-release is getting very close. I believe the CL is almost trivial and very safe to merge.
If we still have some time before the R65 beta, we might want to wait for canary as usual. The problem is that Chrome PFQ has been red for these 10 days.)
Labels: -Merge-Request-65 Merge-Approved-65
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 1 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c1a7353cae349e931b1a79533894674b48ab645

commit 6c1a7353cae349e931b1a79533894674b48ab645
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Thu Feb 01 22:40:30 2018

ext4-migration: Mount with the correct authorization info when starting migration.

The info was lost during a refactoring: 7803fe02870ac7833a30d3c71b15fe0aea159db

BUG= 807856 
TEST=manually try the migration

Change-Id: I5e986b53f099ce3c7c28bbb66fabf6eb7263521d
Reviewed-on: https://chromium-review.googlesource.com/897066
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533580}(cherry picked from commit 41978a3923e22c69057a0910200b691d77c085a3)
Reviewed-on: https://chromium-review.googlesource.com/897283
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#248}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/6c1a7353cae349e931b1a79533894674b48ab645/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc

Status: Fixed (was: Started)

Sign in to add a comment