New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807845 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove OfflinePageModelImpl

Project Member Reported by romax@chromium.org, Feb 1 2018

Issue description

Since Offline Pages has migrated to OfflinePageModelTaskified, remove the old OPMImpl and related code.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0d2b4a5ded41b9f2346118c9402604aef99cb0f

commit b0d2b4a5ded41b9f2346118c9402604aef99cb0f
Author: Yafei Duan <romax@chromium.org>
Date: Thu Feb 01 20:34:47 2018

[Offline Pages] Removing OfflinePageModelImpl.

Removing all OfflinePageModelImpl related code, since we've migrated to
OfflinePageModelTaskified.

Bug:  807845 
Change-Id: Ibe3c0bfbcb090b590c873163959abddad8f2f98d
Reviewed-on: https://chromium-review.googlesource.com/896956
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533802}
[modify] https://crrev.com/b0d2b4a5ded41b9f2346118c9402604aef99cb0f/chrome/browser/ntp_snippets/download_suggestions_provider.cc
[modify] https://crrev.com/b0d2b4a5ded41b9f2346118c9402604aef99cb0f/chrome/browser/offline_pages/android/cct_origin_observer.cc
[modify] https://crrev.com/b0d2b4a5ded41b9f2346118c9402604aef99cb0f/chrome/browser/offline_pages/fresh_offline_content_observer.cc
[modify] https://crrev.com/b0d2b4a5ded41b9f2346118c9402604aef99cb0f/components/ntp_snippets/remote/prefetched_pages_tracker_impl_unittest.cc
[modify] https://crrev.com/b0d2b4a5ded41b9f2346118c9402604aef99cb0f/components/offline_pages/core/BUILD.gn
[modify] https://crrev.com/b0d2b4a5ded41b9f2346118c9402604aef99cb0f/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/b0d2b4a5ded41b9f2346118c9402604aef99cb0f/components/offline_pages/core/model/offline_page_model_taskified.h
[modify] https://crrev.com/b0d2b4a5ded41b9f2346118c9402604aef99cb0f/components/offline_pages/core/offline_page_model.h
[delete] https://crrev.com/31fffd777ed53196263ff1337fd51fe9e4db53ca/components/offline_pages/core/offline_page_model_impl.cc
[delete] https://crrev.com/31fffd777ed53196263ff1337fd51fe9e4db53ca/components/offline_pages/core/offline_page_model_impl.h
[delete] https://crrev.com/31fffd777ed53196263ff1337fd51fe9e4db53ca/components/offline_pages/core/offline_page_model_impl_unittest.cc
[delete] https://crrev.com/31fffd777ed53196263ff1337fd51fe9e4db53ca/components/offline_pages/core/offline_page_model_query.cc
[delete] https://crrev.com/31fffd777ed53196263ff1337fd51fe9e4db53ca/components/offline_pages/core/offline_page_model_query.h
[delete] https://crrev.com/31fffd777ed53196263ff1337fd51fe9e4db53ca/components/offline_pages/core/offline_page_model_query_unittest.cc
[delete] https://crrev.com/31fffd777ed53196263ff1337fd51fe9e4db53ca/components/offline_pages/core/offline_page_storage_manager.cc
[delete] https://crrev.com/31fffd777ed53196263ff1337fd51fe9e4db53ca/components/offline_pages/core/offline_page_storage_manager.h
[delete] https://crrev.com/31fffd777ed53196263ff1337fd51fe9e4db53ca/components/offline_pages/core/offline_page_storage_manager_unittest.cc
[modify] https://crrev.com/b0d2b4a5ded41b9f2346118c9402604aef99cb0f/components/offline_pages/core/stub_offline_page_model.h

Comment 2 by romax@chromium.org, Feb 1 2018

Status: Fixed (was: Started)

Sign in to add a comment