The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a4443f04150a3024c623205f4f276ec53c6a929

commit 6a4443f04150a3024c623205f4f276ec53c6a929
Author: Yuri Wiitala <miu@chromium.org>
Date: Tue Feb 27 22:29:27 2018

Remove unused elements from RWHV::CopyFromSurface() API and dead code.

Removes both: 1) the SkColorType argument; and 2) the ReadbackResponse
enum from the callback. Neither of these is being used meaningfully
anywhere. In addition, migrated Bind→BindOnce for the callback argument.

As a result, this interface change also exposes many obvious now-dead
code paths, and they are also removed: 1) the "decompress bitmap" code
in the Android TabContentManager (java and c++); 2) the extra post-copy
scaling GLHelper readback infrastructure in content/.../surface_utils.*.

Furthermore, due to touched lines of code, there are misc changes to
placate presubmit warnings (e.g., Bind→BindOnce, and test code that was
using content::RunMessageLoopUntilIdle()).

Finally, an order-of-operations bug in the use of CopyFromSurface() was
discovered in headless/... code and was fixed.

Bug:  759310 ,  582955 ,  415682 ,  760348 ,  807843 ,  787941 
Change-Id: I3398761661b7472ef24f40119278ec969a4929d5
Reviewed-on: https://chromium-review.googlesource.com/929874
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539564}
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/chrome/android/java/src/org/chromium/chrome/browser/share/ShareMenuActionHandler.java
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/chrome/browser/android/compositor/tab_content_manager.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/chrome/browser/devtools/devtools_eye_dropper.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/chrome/browser/devtools/devtools_eye_dropper.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/chrome/browser/plugins/plugin_power_saver_browsertest.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/chrome/browser/thumbnails/thumbnail_tab_helper.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/chrome/browser/thumbnails/thumbnail_tab_helper.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/compositor/surface_utils.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/compositor/surface_utils.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/devtools/devtools_frame_trace_recorder.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/frame_host/navigation_entry_screenshot_manager.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/frame_host/navigation_entry_screenshot_manager.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/oop_browsertest.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_browsertest.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_view_browsertest.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/public/android/BUILD.gn
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/public/android/java/src/org/chromium/content_public/browser/ContentBitmapCallback.java
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/public/browser/BUILD.gn
[delete] https://crrev.com/e1d1a13cdd8e14067786c5c81e3aa135e83b85b4/content/public/browser/readback_types.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/content/public/browser/render_widget_host_view.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/extensions/browser/api/web_contents_capture_client.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/extensions/browser/api/web_contents_capture_client.h
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/headless/lib/browser/headless_web_contents_impl.cc
[modify] https://crrev.com/6a4443f04150a3024c623205f4f276ec53c6a929/headless/lib/browser/headless_web_contents_impl.h