[desktop-pwas] Add better support for popping apps into and out of windows. |
|||||||||
Issue descriptionThis is a tracker bug for work related to adding more functionality for bringing PWA tabs into PWA app windows and vice versa. Tasks include: - Pop out the tab into an app window on install - Integrate with the Arc++ pop out button in the location bar
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ac5ecd0c81c0230fbca7bcb6a15fa87e971dc94 commit 7ac5ecd0c81c0230fbca7bcb6a15fa87e971dc94 Author: Christopher Lam <calamity@chromium.org> Date: Mon Feb 05 06:03:35 2018 [desktop-pwas] Reparent WebContents into app window on install. This CL makes desktop PWAs open in windowed mode as soon as they're installed by reparenting the WebContents. Bug: 807842 Change-Id: I2008fa507ee4a8d20bf3d1f8a113ba600370d130 Reviewed-on: https://chromium-review.googlesource.com/877367 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#534335} [modify] https://crrev.com/7ac5ecd0c81c0230fbca7bcb6a15fa87e971dc94/chrome/browser/extensions/bookmark_app_helper.cc [modify] https://crrev.com/7ac5ecd0c81c0230fbca7bcb6a15fa87e971dc94/chrome/browser/extensions/bookmark_app_helper.h [modify] https://crrev.com/7ac5ecd0c81c0230fbca7bcb6a15fa87e971dc94/chrome/browser/extensions/bookmark_app_helper_browsertest.cc [modify] https://crrev.com/7ac5ecd0c81c0230fbca7bcb6a15fa87e971dc94/chrome/browser/ui/browser_commands.cc [modify] https://crrev.com/7ac5ecd0c81c0230fbca7bcb6a15fa87e971dc94/chrome/browser/ui/extensions/application_launch.cc [modify] https://crrev.com/7ac5ecd0c81c0230fbca7bcb6a15fa87e971dc94/chrome/browser/ui/extensions/application_launch.h
,
Feb 21 2018
Bumping to P1, since we will be dropping link capturing ( bug 814102 ), we'll want to provide the user this affordance.
,
Feb 22 2018
,
Feb 22 2018
FWIW, I'm already talking with the ARC++ team about the picker, and it would be nice to keep this foundation-type work consolidated. IMO, popping out is a nice to have, but I'm not sure that it needs to block the launch. We could easily ship it in a later version as an incremental improvement.
,
Feb 22 2018
I think that now we are not automatically link capturing, having a pop out feature should block launch. Otherwise, the user (having already installed the app) may find themselves in a browser tab quite regularly, and want to get back into the app experience.
,
Mar 7 2018
,
Mar 16 2018
The ambient badge work is being tracked in issue 782120.
,
Mar 26 2018
,
Mar 26 2018
,
Mar 27 2018
Keeping this at Pri-1 because I think it adds a new string?
,
Mar 27 2018
,
Mar 27 2018
,
Aug 3
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by calamity@chromium.org
, Feb 5 2018