New issue
Advanced search Search tips

Issue 807827 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Users list on login screen doesn't resize properly after virtual keyboard is dismissed.

Project Member Reported by agawronska@chromium.org, Feb 1 2018

Issue description

Users list in small and extra small layout doesn't adjust height to parent height after virtual keyboard is dismissed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69

commit 68a6654df5d8bdd23681d3e1acb7edeec3ae0b69
Author: Aga Wronska <agawronska@chromium.org>
Date: Fri Feb 02 19:11:59 2018

Make sure users list on login screen resizes properly after virtual keyboard is dismissed.

Add tests for layout of users list after rotation and after
virtual keyboard apperance changes.

Extract LoginKeyboardTestBase class as a base for tests that
need to manipulate virtual keyboard.

Bug:  807827 
Change-Id: I46a300ebbce8a59c9648573fede203ca0f21a292
Reviewed-on: https://chromium-review.googlesource.com/896966
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534115}
[modify] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/BUILD.gn
[modify] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/login/ui/lock_window_unittest.cc
[modify] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/login/ui/login_auth_user_view_unittest.cc
[add] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/login/ui/login_keyboard_test_base.cc
[add] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/login/ui/login_keyboard_test_base.h
[modify] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/login/ui/login_test_base.cc
[modify] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/login/ui/login_test_base.h
[modify] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/login/ui/login_test_utils.cc
[modify] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/login/ui/login_test_utils.h
[modify] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/login/ui/login_user_view_unittest.cc
[modify] https://crrev.com/68a6654df5d8bdd23681d3e1acb7edeec3ae0b69/ash/login/ui/scrollable_users_list_view.cc

Status: Fixed (was: Started)

Sign in to add a comment