New issue
Advanced search Search tips

Issue 807825 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Replace the deprecated usage of setting mirror mode in display settings

Project Member Reported by weidongg@chromium.org, Feb 1 2018

Issue description

Using system display api setDisplayProperties to turn on mirror mode is
deprecated. Replace the usage in display.js with the new api
setMirrorMode.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b05040b1209605d5e8b737bc869126ca1556415

commit 5b05040b1209605d5e8b737bc869126ca1556415
Author: Weidong Guo <weidongg@chromium.org>
Date: Fri Feb 02 22:56:43 2018

Use setMirrorMode in display settings

Changes:
Using system display api setDisplayProperties to turn on mirror mode is
deprecated. Replace the usage in display.js with the new api
setMirrorMode.

BUG= 807825 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I86458ebf7aaa446d6ff23cde05c7eae819d11558
Reviewed-on: https://chromium-review.googlesource.com/896796
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534185}
[modify] https://crrev.com/5b05040b1209605d5e8b737bc869126ca1556415/chrome/browser/about_flags.cc
[modify] https://crrev.com/5b05040b1209605d5e8b737bc869126ca1556415/chrome/browser/resources/settings/device_page/display.js
[modify] https://crrev.com/5b05040b1209605d5e8b737bc869126ca1556415/chrome/test/data/webui/settings/fake_system_display.js
[modify] https://crrev.com/5b05040b1209605d5e8b737bc869126ca1556415/extensions/common/api/system_display.idl
[modify] https://crrev.com/5b05040b1209605d5e8b737bc869126ca1556415/third_party/closure_compiler/externs/system_display.js

Status: Fixed (was: Assigned)

Sign in to add a comment