"PrerenderBrowserTest.PrerenderWindowSize" failing on linux-chromeos-rel . Also flaky apparently. |
||||
Issue description"PrerenderBrowserTest.PrerenderWindowSize" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMwsSBUZsYWtlIihQcmVyZW5kZXJCcm93c2VyVGVzdC5QcmVyZW5kZXJXaW5kb3dTaXplDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Feb 1 2018
failure is [ RUN ] PrerenderBrowserTest.PrerenderWindowSize [30613:31020:0131/210022.351308:ERROR:test_database_manager.cc(64)] Not implemented reached in virtual bool safe_browsing::TestSafeBrowsingDatabaseManager::CheckResourceUrl(const GURL &, safe_browsing::SafeBrowsingDatabaseManager::Client *) [30613:31082:0131/210022.368276:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico ../../chrome/browser/prerender/prerender_browsertest.cc:1084: Failure Value of: DidDisplayPass(web_contents) Actual: false Expected: true I tried reverting r533410 "Allow navigations to opener's site to go back into opener SiteInstance.", but the test still failed. usually it fails mus_browser_tests and browser_tests. One run has just mus_browser_tests failing. The only other suspect I have from 4806 is https://chromium-review.googlesource.com/c/chromium/src/+/895239 "Stop tracking requests that happen after the next page load starts" but maybe the test is just flaky. The test doesn't give out much diagnostic information. Also this bot has really long cycle times :/ I'll disable on ChromeOS -> https://chromium-review.googlesource.com/#/c/chromium/src/+/897302
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46a28e9a0b7d81141609bee53efa3dc89c08c836 commit 46a28e9a0b7d81141609bee53efa3dc89c08c836 Author: Alex Moshchuk <alexmos@chromium.org> Date: Thu Feb 01 06:11:51 2018 Reland "Allow navigations to opener's site to go back into opener SiteInstance." This is a reland of cd5b76ea43df36e2d64447aec0f5da654543133f. PrerenderBrowserTest.PrerenderWindowSize still failing after revert. Original change's description: > Allow navigations to opener's site to go back into opener SiteInstance. > > Previously, when a popup and its opener were cross-site, and neither > site required a dedicated process, navigating the popup back to the > opener's site did not swap processes, so the two ended up in different > processes and couldn't script each other. Even though > DetermineSiteInstanceForURL contains logic to place same-site popups > into their opener's SiteInstance (added as part of the fix for a > similar issue 796912 ), this logic was never reached because we never > attempted a process transfer in this case, thanks to > IsRendererTransferNeededForNavigation() returning false. > > This CL tweaks IsRendererTransferNeededForNavigation so that a > cross-process transfer is always attempted is such cases. This allows > DetermineSiteInstanceForURL to always place the popup that's going back > to its opener site into the opener's SiteInstance. > > Bug: 807184 > Change-Id: Ia4d8d8b2107d3b9e3b9329dd473c06d49b7bd5ec > Reviewed-on: https://chromium-review.googlesource.com/894369 > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533410} TBR=alexmos@chromium.org Bug: 807184 , 807821 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I7808cef9292ff069bcfdd00fe71883d321d7f577 Reviewed-on: https://chromium-review.googlesource.com/897262 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533588} [modify] https://crrev.com/46a28e9a0b7d81141609bee53efa3dc89c08c836/content/browser/frame_host/render_frame_host_manager.cc [modify] https://crrev.com/46a28e9a0b7d81141609bee53efa3dc89c08c836/content/browser/isolated_origin_browsertest.cc [modify] https://crrev.com/46a28e9a0b7d81141609bee53efa3dc89c08c836/content/browser/top_document_isolation_browsertest.cc
,
Feb 1 2018
-> samans@ the failure in https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/50576 is at r533361 so that puts a lower bound on things which is before r533410 the waterfall bot picked that up in https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/4804 There's a suspicious CL there, "content: Send ResizeParams in ViewMsg_WasShown" at r533357 Don't send any WasResized messages when the RenderWidgetHostImpl is hidden, and once it's visible, send the ResizeParams along with the WasShown message. When a WasShown message that has ResizeParams arrives in the renderer, the resize will be performed before setting the visibility to true. This CL makes it easier to send a new LocalSurfaceId to an evicted background tab when it becomes visible. (Allocating a new ID will happen in a subsequent CL)
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e68552a5d503aefdbd4481811cec3af57e797159 commit e68552a5d503aefdbd4481811cec3af57e797159 Author: Trent Apted <tapted@chromium.org> Date: Thu Feb 01 06:37:22 2018 Disable flaky PrerenderBrowserTest.PrerenderWindowSize on ChromeOS TBR=mmenke@chromium.org Bug: 807821 Change-Id: I0e3d42610cea3d87565550dee22e4806959d2893 Reviewed-on: https://chromium-review.googlesource.com/897302 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533597} [modify] https://crrev.com/e68552a5d503aefdbd4481811cec3af57e797159/chrome/browser/prerender/prerender_browsertest.cc
,
Feb 2 2018
,
Feb 5 2018
The blamed CL is reverted. We might be able to turn the test back on. |
||||
►
Sign in to add a comment |
||||
Comment 1 by tapted@chromium.org
, Feb 1 2018