New issue
Advanced search Search tips

Issue 807818 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 678905



Sign in to add a comment

Non-nullable FetchEvent.clientId

Project Member Reported by bashi@chromium.org, Feb 1 2018

Issue description

Spec discussion: https://github.com/w3c/ServiceWorker/issues/1266

We are going to make FetchEvent.clientId non-nullable.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c69da60116b4224fdd4bdf7d5439e1c1d86bb4ec

commit c69da60116b4224fdd4bdf7d5439e1c1d86bb4ec
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Thu Feb 01 05:04:34 2018

Make FetchEvent.clientId non-nullable

The current spec says that it isn't nullable [1]. This CL also removes
null check in client-navigate-worker.js. There is test coverage for null
clientId in fetch-event.https.html so the explicit check here is not
needed.

You can find spec discussion in [2].

[1]
https://github.com/w3c/ServiceWorker/commit/8b483b091e0f0bae6b698cf05d915c2029748ae0
[2] https://github.com/w3c/ServiceWorker/issues/1266

Bug:  807818 
Change-Id: I5ae4f866651931fee732516377b0fa155b0b5e22
Reviewed-on: https://chromium-review.googlesource.com/892762
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533567}
[modify] https://crrev.com/c69da60116b4224fdd4bdf7d5439e1c1d86bb4ec/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt
[modify] https://crrev.com/c69da60116b4224fdd4bdf7d5439e1c1d86bb4ec/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/interfaces-sw.https-expected.txt
[modify] https://crrev.com/c69da60116b4224fdd4bdf7d5439e1c1d86bb4ec/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/client-navigate-worker.js
[modify] https://crrev.com/c69da60116b4224fdd4bdf7d5439e1c1d86bb4ec/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.idl
[modify] https://crrev.com/c69da60116b4224fdd4bdf7d5439e1c1d86bb4ec/third_party/WebKit/Source/modules/serviceworkers/FetchEventInit.idl

Blocking: 678905
Labels: M-66
Status: Fixed (was: Assigned)
Nice!
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71135db54abd58a57d670150239e28375abb421e

commit 71135db54abd58a57d670150239e28375abb421e
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Feb 01 14:45:55 2018

Gardening: NetworkService: add expectation for fetch-event.https.html.

The non-S13nServiceWorker path started passing after  bug 807818  was
fixed, so the S13nServiceWorker path started failing since clientId
isn't implemented there.

TBR=bashi, shimazu

Bug:  807818 , 780405 
NOTRY: true
Change-Id: I3055b18262e3acd3095227db06b2fa9a67f53564
Reviewed-on: https://chromium-review.googlesource.com/897072
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533658}
[add] https://crrev.com/71135db54abd58a57d670150239e28375abb421e/third_party/WebKit/LayoutTests/flag-specific/enable-features=NetworkService/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt

Sign in to add a comment