mac10.13_blink_rel doesn't run layout tests |
||||||
Issue descriptionI fired a try job on tryserver.blink.mac10.13_blink_rel on a test CL modifying LayoutTests/TestExpectations. Here's the build: https://ci.chromium.org/buildbot/tryserver.blink/mac10.13_blink_rel/0 Apparently, layout tests didn't run. For reference, this is the mac10.11_retina_blink_rel build on the same CL: https://ci.chromium.org/buildbot/tryserver.blink/mac10.11_retina_blink_rel/5727 Is the recipe for the bot wrong? https://chromium-review.googlesource.com/c/chromium/tools/build/+/862893/5/scripts/slave/recipe_modules/chromium_tests/trybots.py Shall we use chromium.webkit as the master for mac10.13_blink_rel? Or is there some other issue I missed?
,
Feb 1 2018
+jbudorick On a side note, the bot doesn't seem to have LogDog.
,
Feb 1 2018
It's not that it doesn't run the layout tests, it doesn't run anything :). We need to add the tests we want to run to //testing/buildbot. Posting a CL for that now. Why do you think it doesn't have LogDog?
,
Feb 1 2018
Re #3: stdio of each step is stored on build.chromium.org instead of logs.chromium.org, and there is no LogDog bootstrap step. Is that normal?
,
Feb 1 2018
build #0 of buildbots is usually a little weird. Build #1 looks more normal. CL: https://crrev.com/c/898210 https://ci.chromium.org/buildbot/tryserver.blink/mac10.13_blink_rel/1
,
Feb 2 2018
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a85f2acd5b71df9d409e4fcb82ff0460c253d653 commit a85f2acd5b71df9d409e4fcb82ff0460c253d653 Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Feb 02 02:35:43 2018 Fix the test suite config for mac10.13_blink_rel. The mac10.13_blink_rel was not running any tests, because the builder it was set up to mirror ("Dummy WebKit Mac10.13") was on the wrong waterfall. R=robertma@chromium.org BUG= 807817 Change-Id: I067f5f12dde2cdca89959ec59afeaed45d2296cc Reviewed-on: https://chromium-review.googlesource.com/898210 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#533928} [modify] https://crrev.com/a85f2acd5b71df9d409e4fcb82ff0460c253d653/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/a85f2acd5b71df9d409e4fcb82ff0460c253d653/testing/buildbot/chromium.webkit.json [modify] https://crrev.com/a85f2acd5b71df9d409e4fcb82ff0460c253d653/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/a85f2acd5b71df9d409e4fcb82ff0460c253d653/testing/buildbot/waterfalls.pyl
,
Feb 2 2018
This should be fixed now (though a large number of tests will fail).
,
Feb 2 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by robertma@chromium.org
, Feb 1 2018