"InputRouterImplScaleGestureEventTest.GestureFlingStart" is flaky |
|||||||||
Issue description"InputRouterImplScaleGestureEventTest.GestureFlingStart" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQQsSBUZsYWtlIjZJbnB1dFJvdXRlckltcGxTY2FsZUdlc3R1cmVFdmVudFRlc3QuR2VzdHVyZUZsaW5nU3RhcnQM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Feb 2 2018
Failure log is:
[ RUN ] InputRouterImplScaleGestureEventTest.GestureFlingStart
[3:171726857:0201/233530.633230:334537197:ERROR:base_paths_fuchsia.cc(37)] Not implemented reached in bool base::PathProviderFuchsia(int, base::FilePath *)
../../content/browser/renderer_host/input/input_router_impl_unittest.cc:2368: Failure
Expected equality of these values:
2u
Which is: 2
dispatched_messages_.size()
Which is: 0
[ FAILED ] InputRouterImplScaleGestureEventTest.GestureFlingStart (255 ms)
,
Feb 2 2018
This is flaky only on fuchsia_x64.
,
Feb 2 2018
,
Feb 2 2018
I'm going to disable this test on Fuchsia.
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07cb42928d37de6bc816b36af12aab2a7382d1cc commit 07cb42928d37de6bc816b36af12aab2a7382d1cc Author: Yuta Kitamura <yutak@chromium.org> Date: Fri Feb 02 06:26:11 2018 Disable InputRouterImplScaleGestureEventTest.GestureFlingStart on Fuchsia. This test is flaky on Fuchsia. TBR=treib@chromium.org,sfiera@chromium.org,sahel@chromium.org,tdresser@chromium.org Bug: 807803 Change-Id: Ie05cca6552c447af612bb36cb86663a8ba118b05 Reviewed-on: https://chromium-review.googlesource.com/898763 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533976} [modify] https://crrev.com/07cb42928d37de6bc816b36af12aab2a7382d1cc/content/browser/renderer_host/input/input_router_impl_unittest.cc
,
Feb 2 2018
The test was disabled, but we need to find a right owner for this. sahel: Do you have any idea on this?
,
Feb 5 2018
Issue 808454 has been merged into this issue.
,
Feb 5 2018
LegacyInputRouterImplScaleGestureEventTest.GestureFlingStart is also flaky in the same way. I'm going to disable this as well.
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eac223255d2284a9fb861c210d08b8757dc950a2 commit eac223255d2284a9fb861c210d08b8757dc950a2 Author: Yuta Kitamura <yutak@chromium.org> Date: Mon Feb 05 05:43:14 2018 Disable LegacyInputRouterImplScaleGestureEventTest.GestureFlingStart on Fuchsia. This test is flaky on Fuchsia. TBR=sfiera@chromium.org Bug: 807803 Change-Id: I2426a2689381d5f33b3c7a22bbc7ef3af014bc64 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/899704 Reviewed-by: Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#534334} [modify] https://crrev.com/eac223255d2284a9fb861c210d08b8757dc950a2/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc
,
Feb 5 2018
OK, we now want someone who can own this. Spamming a few more folks... (but I'm not really sure if there's anyone who can work on fuchsia)
,
Feb 5 2018
Over to sahel@. She is working on GestureFling tests.
,
Feb 6 2018
,
May 2 2018
Marked as Wontfix since https://chromium-review.googlesource.com/c/chromium/src/+/994181 removes the flaky test. Reason for removing: With browser side fling this test is not needed anymore since no GFS is sent to the renderer, instead the fling controller generates and sends GSU events to the renderer. Sending the GSU events is already covered in the following test: InputRouterImplScaleGestureEventTest.GestureScrollUpdate |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by chromium...@appspot.gserviceaccount.com
, Feb 1 2018