New issue
Advanced search Search tips

Issue 807786 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

[Autofill] Multiple hidden section causes field-by-field.

Project Member Reported by parastoog@chromium.org, Jan 31 2018

Issue description

Sometimes multiple forms are hidden and we fail at sectioning them.

www.cvs.com

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7121ddfce5ca5f952cf86a8a9e1b45307c25edd8

commit 7121ddfce5ca5f952cf86a8a9e1b45307c25edd8
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Tue Feb 13 23:47:39 2018

[Autofill] Fill the most recent version of forms.

Problem:

When filling forms, some parameters keep changing.
A field can go from hidden to visible, or .. . These changes affect
our decisions, and we need to make the decisions based on the most
recent version of the form.

Example: When filling the forms in www.cvs.com, both address forms
are initially hidden, and will appear one by one. Currently, this
causes a field-by-field situation for the second address form.

Solution:

Look at the most recent version of the form when filling it.
To do so, we need not to update the whole form from the cached one,
but only retrieve the server data, such as the form signature and
the server type predictions.

Note:

Since, after this change, we will know the visibility of a field
at the time of filling the form, IdentifySection can be simplified.
It will no more need to handle hidden cases.

Bug:  807786 
Change-Id: I94c2c877560b1705b60468f3adef87480603a974
Reviewed-on: https://chromium-review.googlesource.com/905785
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#536556}
[modify] https://crrev.com/7121ddfce5ca5f952cf86a8a9e1b45307c25edd8/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/7121ddfce5ca5f952cf86a8a9e1b45307c25edd8/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/7121ddfce5ca5f952cf86a8a9e1b45307c25edd8/components/autofill/core/browser/form_structure.h

Labels: TE-NeedsTriageFromMTV Needs-Feedback
Tried verifying the fix on the latest Canary 66.0.3347.0, but the site www.cvs.com is unavailable in India to test.
Hence adding TE-NeedsTriageFromMTV label to verify the fix on the latest Canary.

parastoog@ Can you please let us know if any other alternate site is available to verify this issue.

Thanks..
Status: Fixed (was: Started)

Sign in to add a comment