[Autofill] Form appearing in multiple groups result in field by field. |
||
Issue descriptionFor some sites the form appears in multiple groups over time. This causes field by field from second group onward, because we group them all as one section. oup.com
,
Feb 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06d2bd76848c55f40720eb66351b43085a2bccc1 commit 06d2bd76848c55f40720eb66351b43085a2bccc1 Author: Parastoo Geranmayeh <parastoog@google.com> Date: Tue Feb 20 20:55:11 2018 [Autofill] Don't fill the hidden fields. Problem: Sometimes, one section of a form appears in multiple groups over time. This causes field by field situation from second group onward, because we group them all as one section, and would consider the fields which appear later as already filled. This is also an inconsistency, because the browser side fills them, but the renderer side doesn't. Examples: oup.com tradepub.com Solution: Don't fill hidden fields on the browser side. This way, they can get filled in later steps for real. This is also more consistent with a real user's action. As a result of this change, we can no more say if a section is autofilled as a unit. Some fields may be autofilled and some may not. We should consider the fields separately. So, we should take care of: 1.filling/previewing the form. 2.deciding if a credit card number will be filled. Tests added and modified. Note: Previously we would fill the hidden fields (on browser side), because we were not looking at the most updated version of the form, and couldn't trust the given visibility status of a field. This is not the case anymore. This change is based on the new version. Bug: 807780 Change-Id: I297ef33ce5952bab8ff5fce90bf4fc4d6a09731e Reviewed-on: https://chromium-review.googlesource.com/919525 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537875} [modify] https://crrev.com/06d2bd76848c55f40720eb66351b43085a2bccc1/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/06d2bd76848c55f40720eb66351b43085a2bccc1/components/autofill/core/browser/autofill_manager_unittest.cc
,
Feb 20 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by parastoog@chromium.org
, Feb 8 2018