New issue
Advanced search Search tips

Issue 807764 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 638318

Blocking:
issue 807768



Sign in to add a comment

Refactor android.test.mock dependents with Mockito

Project Member Reported by yolandyan@chromium.org, Jan 31 2018

Issue description

android.test.mock is deprecated and any test that utilizes android.test.mock should be refactored to use Mockito instead.

This bug is created to keep this progress
 
Blocking: 807768
Can we use Mockito in our instrumentation tests?  I thought it was only available in our junit tests.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb76c8ae7cd2135463f77130066fce3b9963416b

commit bb76c8ae7cd2135463f77130066fce3b9963416b
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Jun 22 21:37:04 2018

Switch AppBannerManagerTest from MockPackageManager to mockito.

Bug: 807764
Change-Id: I0758c2939049e22b60d653f69ce7537cb283487a
Reviewed-on: https://chromium-review.googlesource.com/1103598
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569792}
[modify] https://crrev.com/bb76c8ae7cd2135463f77130066fce3b9963416b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/bb76c8ae7cd2135463f77130066fce3b9963416b/chrome/android/BUILD.gn
[modify] https://crrev.com/bb76c8ae7cd2135463f77130066fce3b9963416b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

I made 2 patches for this issue.

https://chromium-review.googlesource.com/c/chromium/src/+/1133606
https://chromium-review.googlesource.com/c/chromium/src/+/1131155

But, tests are failing in kitkat tests.
Is there any solution for this?

Sign in to add a comment