Issue metadata
Sign in to add a comment
|
mosys won't compile (can't find headers) after repo sync to 74e541a |
||||||||||||||||||||||
Issue description
What steps will reproduce the problem?
(1) repo sync so mosys repo is at 74e541a (HEAD, m/master, cros/master) Correct a bug in string_in_list()
(2) cros_workon-coral start mosys
(3) emerge-coral mosys
What is the expected result?
Compile successfully
What happens instead?
Errors with headers not being found, e.g.
...
core/callbacks.c:34:10: fatal error: 'mosys/alloc.h' file not found
#include "mosys/alloc.h"
^~~~~~~~~~~~~~~
1 error generated.
LD lib/crypto/mincrypt/built-in.o
make[1]: *** [scripts/Makefile.build:230: core/callbacks.o] Error 1
make[1]: *** Waiting for unfinished jobs....
core/file_backed_range.c:35:10: fatal error: 'mosys/file_backed_range.h' file not found
#include "mosys/file_backed_range.h"
,
Feb 1 2018
+YH
,
Feb 2 2018
It seems that mosys is currently failing because https://cs/chromeos_public/src/platform/mosys/.gitignore contains "mosys", which ends up blacklisting the include/mosys directory in the unpack phase. I don't see any reason this should have started failing recently though.
,
Feb 2 2018
Looking at this now.
,
Feb 2 2018
Fix out for review: https://chromium-review.googlesource.com/c/chromiumos/platform/mosys/+/900059 Nice find, Nick.
,
Feb 2 2018
,
Feb 3 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/e21cfbfe805dbdd8bb491d7d92c40b5b77f0684d commit e21cfbfe805dbdd8bb491d7d92c40b5b77f0684d Author: Jason D. Clinton <jclinton@chromium.org> Date: Sun Feb 04 16:12:46 2018 .gitignore: Be explicit about the paths that are ignored The recent Portage upgrade seems to have started honoring .gitignore when doing a from-source-directory build. This .gitignore was historically wrong but, apparently, people have been hacking around it. This CL just fixes the .gitignore to be what it should have been all along. BUG= chromium:807757 TEST=cros_workon --board=reef start mosys; emerge-reef mosys succeeds BRANCH=none Change-Id: I3b82af5ddd1ee00d2518aa9062948aa6a025b356 Reviewed-on: https://chromium-review.googlesource.com/900059 Tested-by: Jason Clinton <jclinton@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> Tested-by: Nick Sanders <nsanders@chromium.org> Reviewed-by: Patrick Berny <pberny@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> [modify] https://crrev.com/e21cfbfe805dbdd8bb491d7d92c40b5b77f0684d/.gitignore
,
Feb 4 2018
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/cf893226a7f781a230964a172944a05261cc4994 commit cf893226a7f781a230964a172944a05261cc4994 Author: Jason D. Clinton <jclinton@chromium.org> Date: Tue Feb 06 06:24:39 2018 .gitignore: Be explicit about the paths that are ignored The recent Portage upgrade seems to have started honoring .gitignore when doing a from-source-directory build. This .gitignore was historically wrong but, apparently, people have been hacking around it. This CL just fixes the .gitignore to be what it should have been all along. BUG= chromium:807757 TEST=cros_workon --board=reef start mosys; emerge-reef mosys succeeds BRANCH=none Change-Id: I3b82af5ddd1ee00d2518aa9062948aa6a025b356 Reviewed-on: https://chromium-review.googlesource.com/900059 Tested-by: Jason Clinton <jclinton@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> Tested-by: Nick Sanders <nsanders@chromium.org> Reviewed-by: Patrick Berny <pberny@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> (cherry picked from commit e21cfbfe805dbdd8bb491d7d92c40b5b77f0684d) Reviewed-on: https://chromium-review.googlesource.com/903255 Commit-Queue: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Trybot-Ready: Patrick Berny <pberny@chromium.org> [modify] https://crrev.com/cf893226a7f781a230964a172944a05261cc4994/.gitignore
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/b6ba8a6a87543c4b69fc245ef8f085b0d681fac6 commit b6ba8a6a87543c4b69fc245ef8f085b0d681fac6 Author: Jason D. Clinton <jclinton@chromium.org> Date: Thu Feb 08 00:09:58 2018 .gitignore: Be explicit about the paths that are ignored The recent Portage upgrade seems to have started honoring .gitignore when doing a from-source-directory build. This .gitignore was historically wrong but, apparently, people have been hacking around it. This CL just fixes the .gitignore to be what it should have been all along. BUG= chromium:807757 TEST=cros_workon --board=reef start mosys; emerge-reef mosys succeeds BRANCH=none Change-Id: I3b82af5ddd1ee00d2518aa9062948aa6a025b356 Reviewed-on: https://chromium-review.googlesource.com/900059 Tested-by: Jason Clinton <jclinton@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> Tested-by: Nick Sanders <nsanders@chromium.org> Reviewed-by: Patrick Berny <pberny@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> (cherry picked from commit e21cfbfe805dbdd8bb491d7d92c40b5b77f0684d) Reviewed-on: https://chromium-review.googlesource.com/902344 Reviewed-by: Jason Clinton <jclinton@chromium.org> Commit-Queue: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Trybot-Ready: Patrick Berny <pberny@chromium.org> [modify] https://crrev.com/b6ba8a6a87543c4b69fc245ef8f085b0d681fac6/.gitignore
,
Feb 12 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 12 2018
,
Feb 12 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pbe...@chromium.org
, Jan 31 2018