New issue
Advanced search Search tips

Issue 807752 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::Frame::IsFeatureEnabled

Project Member Reported by ClusterFuzz, Jan 31 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5313072315760640

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::Frame::IsFeatureEnabled
  blink::PictureInPictureController::GetStatus
  blink::PictureInPictureController::PictureInPictureEnabled
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=463867:463893

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5313072315760640

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 31 2018

Cc: mcasas@chromium.org dcheng@chromium.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Rename GetLayout()/GetLayoutBlock() to UpdateLayout()/UpdateBlockLayout() by dcheng@chromium.org - https://chromium.googlesource.com/chromium/src/+/ed375c02e956ef832e8ed6223435f0d78d6bdf77

Image Capture: replace OriginTrialEnable with RuntimeEnable and mark it 'stable' by mcasas@chromium.org - https://chromium.googlesource.com/chromium/src/+/44e0ad0c40c920ab5259514c5ea262c8bd7cd5a5

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 2 by ClusterFuzz, Feb 1 2018

Labels: M-65 ReleaseBlock-Beta ClusterFuzz-Top-Crash
Testcase 5313072315760640 is a top crash on ClusterFuzz for mac platform. Please prioritize fixing this crash.

Marking this crash as a Beta release blocker.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Cc: beaufort...@gmail.com
Components: Blink>Media>PictureInPicture
Owner: mlamouri@chromium.org
Status: Assigned (was: Untriaged)
As this is a document supplement, I suspect it can be called on a document after it's been detached from a frame. In that case, deferencing frame here will crash: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/picture_in_picture/PictureInPictureController.cpp?rcl=2768203553deae4587be1b6840b4e06f02f8c870&l=54

Francois or Mounir, do you mind taking a look at this? The fix is easy enough, but I don't know enough about the API to write a test.
M65 Beta promotion is coming soon and your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and request a merge to M65 branch 3325 ASAP (merge has to be done latest by Monday, 02/05 @ 1:00 PM PT). Thank you.
Cc: mlamouri@chromium.org
Owner: fbeaufort@chromium.org
Labels: -ReleaseBlock-Beta -M-65 M-66
Dropping Beta-Blocker and M-65 as this code has landed in M66. I have issues looking at the clusterfuzz website so I can't confirm if the issue is on the bug report or clusterfuzz itself.
Project Member

Comment 9 by ClusterFuzz, Feb 8 2018

ClusterFuzz has detected this issue as fixed in range 534993:534994.

Detailed report: https://clusterfuzz.com/testcase?key=5313072315760640

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::Frame::IsFeatureEnabled
  blink::PictureInPictureController::GetStatus
  blink::PictureInPictureController::PictureInPictureEnabled
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=463867:463893
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=534993:534994

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5313072315760640

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Feb 8 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5313072315760640 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment