Null-dereference READ in blink::Frame::IsFeatureEnabled |
||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5313072315760640 Fuzzer: inferno_twister_c Job Type: linux_ubsan_vptr_content_shell_drt Platform Id: linux Crash Type: Null-dereference READ Crash Address: 0x000000000000 Crash State: blink::Frame::IsFeatureEnabled blink::PictureInPictureController::GetStatus blink::PictureInPictureController::PictureInPictureEnabled Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=463867:463893 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5313072315760640 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Feb 1 2018
Testcase 5313072315760640 is a top crash on ClusterFuzz for mac platform. Please prioritize fixing this crash. Marking this crash as a Beta release blocker. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Feb 1 2018
As this is a document supplement, I suspect it can be called on a document after it's been detached from a frame. In that case, deferencing frame here will crash: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/picture_in_picture/PictureInPictureController.cpp?rcl=2768203553deae4587be1b6840b4e06f02f8c870&l=54 Francois or Mounir, do you mind taking a look at this? The fix is easy enough, but I don't know enough about the API to write a test.
,
Feb 2 2018
M65 Beta promotion is coming soon and your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and request a merge to M65 branch 3325 ASAP (merge has to be done latest by Monday, 02/05 @ 1:00 PM PT). Thank you.
,
Feb 2 2018
,
Feb 2 2018
Dropping Beta-Blocker and M-65 as this code has landed in M66. I have issues looking at the clusterfuzz website so I can't confirm if the issue is on the bug report or clusterfuzz itself.
,
Feb 2 2018
The WIP CL is available at https://chromium-review.googlesource.com/c/chromium/src/+/898982
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de5671d5ab239e09e1e4548a2d8e1a42e404478b commit de5671d5ab239e09e1e4548a2d8e1a42e404478b Author: François Beaufort <beaufort.francois@gmail.com> Date: Wed Feb 07 13:27:29 2018 [Picture-in-Picture] Fix crash when document is detached from a frame. Bug: 807752 , 806249 Change-Id: Ia6d396ab7bb931c4ef5195422c38b8eb2156250e Reviewed-on: https://chromium-review.googlesource.com/898982 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#534994} [modify] https://crrev.com/de5671d5ab239e09e1e4548a2d8e1a42e404478b/third_party/WebKit/Source/modules/picture_in_picture/HTMLVideoElementPictureInPicture.cpp [modify] https://crrev.com/de5671d5ab239e09e1e4548a2d8e1a42e404478b/third_party/WebKit/Source/modules/picture_in_picture/PictureInPictureController.cpp [modify] https://crrev.com/de5671d5ab239e09e1e4548a2d8e1a42e404478b/third_party/WebKit/Source/modules/picture_in_picture/PictureInPictureController.h
,
Feb 8 2018
ClusterFuzz has detected this issue as fixed in range 534993:534994. Detailed report: https://clusterfuzz.com/testcase?key=5313072315760640 Fuzzer: inferno_twister_c Job Type: linux_ubsan_vptr_content_shell_drt Platform Id: linux Crash Type: Null-dereference READ Crash Address: 0x000000000000 Crash State: blink::Frame::IsFeatureEnabled blink::PictureInPictureController::GetStatus blink::PictureInPictureController::PictureInPictureEnabled Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=463867:463893 Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=534993:534994 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5313072315760640 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Feb 8 2018
ClusterFuzz testcase 5313072315760640 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ClusterFuzz
, Jan 31 2018Labels: Test-Predator-Auto-CC