[Autofill] More field types (= UNKNOWN) |
||||||
Issue descriptionBy having more field types that are practically equivalent to UNKNOWN fields we may be able to improve the field detection. Right now, if the heuristics mark a field as UNKONWN, the server's vote would overwrite the heuristics, even if the percent of votes are not large enough. By adding these fields we can avoid this. Suggested field types: -- Birthday (or non-expiration dates in general, such as flight date, booking date, etc. They usually have day as well as month and year.) -- Quantity/Size/Height (vs exp month) -- Search Term -- Promo code -- Title -- P.O. Box -- Price (See Tommy's comment.) We already have phone extension.
,
Feb 21 2018
,
Feb 21 2018
,
Feb 22 2018
,
Mar 2 2018
I think this will be very useful. We do need to make sure that they are not discarded in favor of the server predictions thought. Suggestion: create a group type for all these fields for which we have no data / do not fill. Then we can decide to trust the heuristics when they are of that group type. WDYT?
,
Mar 2 2018
Sounds like an OK plan, but what if heuristics get it wrong and we want to override from the server? Protocol probably needs to be changed. Let's create another private bug to discuss the server protocol change.
,
Mar 2 2018
Yes I like your idea of a granularity between a "normal" server prediction and an "overriden" server prediction. Will open a bug
,
Mar 2 2018
created crbug.com/818188
,
Mar 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/955ec783ee302195219b9eb0cdc383c0fd778562 commit 955ec783ee302195219b9eb0cdc383c0fd778562 Author: Parastoo Geranmayeh <parastoog@google.com> Date: Mon Mar 05 17:53:56 2018 [Autofill] Add Search Term as a heuristic type. Problem: Search fields appear in the forms, and they are sometimes detected incorrectly by server. One reason for this is that we don't fill search fields and thus the detected heuristics type for them is UNKNOWN. Example: venus.com. Solution: By having more field types that are practically equivalent to UNKNOWN fields we may be able to improve the field type detection. This would be the case where we do predict a type for a field on the heuristics, but will not fill it at the end. Bug: 807748 Change-Id: Ide4177fcbc5dce5ff14d5371720db1edc8be0643 Reviewed-on: https://chromium-review.googlesource.com/944515 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#540861} [modify] https://crrev.com/955ec783ee302195219b9eb0cdc383c0fd778562/components/autofill/core/browser/address_field.cc [modify] https://crrev.com/955ec783ee302195219b9eb0cdc383c0fd778562/components/autofill/core/browser/address_field.h [modify] https://crrev.com/955ec783ee302195219b9eb0cdc383c0fd778562/components/autofill/core/browser/address_field_unittest.cc [modify] https://crrev.com/955ec783ee302195219b9eb0cdc383c0fd778562/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/955ec783ee302195219b9eb0cdc383c0fd778562/components/autofill/core/browser/autofill_profile.cc [modify] https://crrev.com/955ec783ee302195219b9eb0cdc383c0fd778562/components/autofill/core/browser/autofill_type.cc [modify] https://crrev.com/955ec783ee302195219b9eb0cdc383c0fd778562/components/autofill/core/browser/field_types.h [modify] https://crrev.com/955ec783ee302195219b9eb0cdc383c0fd778562/components/autofill/core/common/autofill_regex_constants.cc [modify] https://crrev.com/955ec783ee302195219b9eb0cdc383c0fd778562/components/autofill/core/common/autofill_regex_constants.h [add] https://crrev.com/955ec783ee302195219b9eb0cdc383c0fd778562/components/test/data/autofill/heuristics/input/150_checkout_venus.com_search_field.html [add] https://crrev.com/955ec783ee302195219b9eb0cdc383c0fd778562/components/test/data/autofill/heuristics/output/150_checkout_venus.com_search_field.out
,
Apr 9 2018
,
Sep 24
Ran into an issue with "Name your price" being marked as a first name field, so Autofill wants me to pay $Tommy 🙃 Observed on https://alvvays.bandcamp.com/album/antisocialites
,
Sep 24
,
Sep 24
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by parastoog@chromium.org
, Feb 20 2018