New issue
Advanced search Search tips

Issue 807746 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression


Participants' hotlists:
Hotlist-1


Sign in to add a comment

Print file dialog creates folder

Reported by mohduma...@gmail.com, Jan 31 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

Steps to reproduce the problem:
1. Open any website and open print dialog
2. Save as pdf in a directory e.g. C:\docs
3. Do not close chrome. Delete C:\docs
4. Open any website again and print to pdf
5. Now as soon as file save as pdf dialog opens, the history of this dialog causes C:\docs to recreate itself 

What is the expected behavior?
File save as dialog should not create folder. It should open some default dir like desktop

What went wrong?
Print save as pdf dialog history causes folder to recreate itself

Did this work before? N/A 

Chrome version: 63.0.3239.132  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 28.0 r0

problem on linux and windows
 
Labels: Needs-Triage-M63
Labels: Needs-Bisect
Components: Internals>Printing
Labels: -Type-Bug -Pri-2 -Needs-Bisect RegressedIn-61 Triaged-ET M-66 FoundIn-66 Target-66 hasbisect OS-Linux Pri-1 Type-Bug-Regression
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10 and Ubuntu 14.04 using chrome reported version #63.0.3239.132 and latest canary #66.0.3340.0.

Bisect Information:
=====================
Good build: 61.0.3138.0
Bad Build : 61.0.3139.0

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/11464f93e041d5b6ae47e2f8dfb2765ab727d7e8..1d79be78d43dbda5406eee2aef523bdb791d4d49

From the above change log suspecting below change
Review-Url: https://codereview.chromium.org/2952043002

rbpotter@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!
Status: WontFix (was: Assigned)
This is working as intended. If you check the bug that is linked to the CL ( https://crbug.com/718527 ), you will see that this behavior was specifically requested in order to match what happens with Downloads. 
NO this is not working as intended.

The downloads location specified in the settings is NOT what is used by default in the dialog.

Instead print dialog is using the last saved location as default, which can definitely be anything other than the downloads folder selected in the settings.

The dialog should be instructed to use the default location when it opens and NOT the last saved location.


Labels: -Pri-1 Pri-2
Status: Assigned (was: WontFix)
Comment 5, thank you for clarifying the original request. Did some additional investigation and it sounds like the issue is that print preview creates folders that are not the default location. To match the Downloads behavior we should:
(1) Use the most recently used directory if it exists (this is already working).
(2) If not, use the default location, and create it if it does not exist. We already do the second part, which is what the bug linked in comment 4 was referring to. However, we also recreate the most recent directory if it doesn't exist, which Downloads does not do.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df8926bba217b1d5bcf7e004b3767b035b9fe798

commit df8926bba217b1d5bcf7e004b3767b035b9fe798
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Feb 07 20:19:23 2018

Print Preview: Do not create non default directories for Save as PDF

Bug:  807746 
Change-Id: I21b5add06d217835de3f8f1d2b9cf98df7d92416
Reviewed-on: https://chromium-review.googlesource.com/905336
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535126}
[modify] https://crrev.com/df8926bba217b1d5bcf7e004b3767b035b9fe798/chrome/browser/ui/webui/print_preview/pdf_printer_handler.cc
[modify] https://crrev.com/df8926bba217b1d5bcf7e004b3767b035b9fe798/chrome/browser/ui/webui/print_preview/pdf_printer_handler.h

Labels: TE-Verified-66.0.3343.0 TE-Verified-M66
Verified the fix on Win-10 and Ubuntu 14.04 using latest chrome version #66.0.3343.0 as per the comment #0.
Attaching screen cast for reference.
Observed that file save as dialog did not create folder. It opened some default dir i.e downloads.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
807746.mp4
2.0 MB View Download
Status: Fixed (was: Assigned)

Sign in to add a comment