New issue
Advanced search Search tips

Issue 807744 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

font-feature-settings should follow the shortest-serialization principle

Project Member Reported by cnardi@chromium.org, Jan 31 2018

Issue description

From the discussion on https://bugzilla.mozilla.org/show_bug.cgi?id=1434698, Chrome/WebKit serializes the default value of '1' or 'on' in font-feature-settings, even though this isn't necessary. See https://github.com/w3c/csswg-drafts/issues/1564 for the least-serialization principle.
 
Labels: Hotlist-Interop
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba54acda15a6bba509527790751c01233b9da91f

commit ba54acda15a6bba509527790751c01233b9da91f
Author: Chris Nardi <cnardi@chromium.org>
Date: Thu Feb 01 05:02:23 2018

Leave out the default value when serializing font-feature-settings

According to the shortest-serialization principle [1], values should be
omitted if their omission wouldn't change the value of reparsing. As
"1"/"on" is the default value for font-feature-settings, omit this when
serializing, matching the behavior of Firefox.

[1]: https://github.com/w3c/csswg-drafts/issues/1564

Bug:  807744 
Change-Id: Ieb8b86aa66aa303a82a895c42373177cf7f13d07
Reviewed-on: https://chromium-review.googlesource.com/896203
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533566}
[modify] https://crrev.com/ba54acda15a6bba509527790751c01233b9da91f/third_party/WebKit/LayoutTests/css3/font-feature-settings-parsing-expected.txt
[modify] https://crrev.com/ba54acda15a6bba509527790751c01233b9da91f/third_party/WebKit/LayoutTests/css3/font-feature-settings-parsing.html
[modify] https://crrev.com/ba54acda15a6bba509527790751c01233b9da91f/third_party/WebKit/LayoutTests/css3/fonts/font-feature-settings-parsing-prefixed-expected.txt
[modify] https://crrev.com/ba54acda15a6bba509527790751c01233b9da91f/third_party/WebKit/LayoutTests/css3/fonts/font-feature-settings-parsing-prefixed.html
[modify] https://crrev.com/ba54acda15a6bba509527790751c01233b9da91f/third_party/WebKit/LayoutTests/external/wpt/css/css-fonts/font-feature-settings-serialization-001.html
[modify] https://crrev.com/ba54acda15a6bba509527790751c01233b9da91f/third_party/WebKit/LayoutTests/fast/css/fontface-properties-expected.txt
[modify] https://crrev.com/ba54acda15a6bba509527790751c01233b9da91f/third_party/WebKit/LayoutTests/fast/css/fontface-properties.html
[modify] https://crrev.com/ba54acda15a6bba509527790751c01233b9da91f/third_party/WebKit/LayoutTests/fast/css/inherited-properties-rare-text-expected.txt
[modify] https://crrev.com/ba54acda15a6bba509527790751c01233b9da91f/third_party/WebKit/Source/core/css/CSSFontFeatureValue.cpp

Status: Fixed (was: Started)

Sign in to add a comment