New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807739 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix CredentialManagerBrowserTest.* tests with network service.

Project Member Reported by jcivelli@chromium.org, Jan 31 2018

Issue description

The CredentialManagerBrowserTest tests are failing because the cert verifier is not hooked up and loading an HTTPS page ends up showing an interstitial.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a256f1c9a3f7f6dc01dd00eeb213c3558664c728

commit a256f1c9a3f7f6dc01dd00eeb213c3558664c728
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Feb 01 19:43:57 2018

Fixing CredentialManagerBrowserTests tests with the network service.

Making the CredentialManagerBrowserTests work with the network service.
They were failing because the certificate verifier was not set up for
the network service and an interstitial would be shown when navigating
to an HTTPS page.

Bug:  807739 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I11500770f119c677b4a5b62f929b3e09dafd5047
Reviewed-on: https://chromium-review.googlesource.com/896869
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533778}
[modify] https://crrev.com/a256f1c9a3f7f6dc01dd00eeb213c3558664c728/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/a256f1c9a3f7f6dc01dd00eeb213c3558664c728/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/a256f1c9a3f7f6dc01dd00eeb213c3558664c728/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/a256f1c9a3f7f6dc01dd00eeb213c3558664c728/chrome/browser/password_manager/password_manager_test_base.h
[modify] https://crrev.com/a256f1c9a3f7f6dc01dd00eeb213c3558664c728/chrome/test/BUILD.gn
[modify] https://crrev.com/a256f1c9a3f7f6dc01dd00eeb213c3558664c728/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Status: Fixed (was: Untriaged)

Sign in to add a comment