Fix StaticFieldLeak in ChromeHomeSurveyController |
||
Issue description
1. Remove @SuppressLint("StaticFieldLeak") in ChromeHomeSurveyController.java
2. Build and see lint error
3. Fix
From: http://tools.android.com/tips/lint-checks
StaticFieldLeak
---------------
Summary: Static Field Leaks
Priority: 6 / 10
Severity: Warning
Category: Performance
A static field will leak contexts.
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc3df65974a415ed2a9475a7a41e792f2f250785 commit fc3df65974a415ed2a9475a7a41e792f2f250785 Author: Daniel Park <danielpark@chromium.org> Date: Wed Mar 07 20:31:25 2018 [Chrome Home Survey] Removes context as static field. Retrieves context with #getApplicationContext Bug: 807728 Change-Id: Ic44fae78c07519819289deefcb4f5f5fb28dc858 Reviewed-on: https://chromium-review.googlesource.com/946742 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#541558} [modify] https://crrev.com/fc3df65974a415ed2a9475a7a41e792f2f250785/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/fc3df65974a415ed2a9475a7a41e792f2f250785/chrome/android/java/src/org/chromium/chrome/browser/survey/ChromeHomeSurveyController.java
,
Mar 7 2018
,
Mar 7 2018
Thank you for fixing this Daniel! |
||
►
Sign in to add a comment |
||
Comment 1 by danielpark@chromium.org
, Mar 2 2018