Direct-leak in content::MediaFactory::EncryptedMediaClient |
|||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5298990191738880 Fuzzer: inferno_layout_test_unmodified Job Type: linux_lsan_chrome_mp Platform Id: linux Crash Type: Direct-leak Crash Address: Crash State: content::MediaFactory::EncryptedMediaClient blink::MediaKeysController::EncryptedMediaClient blink::NavigatorRequestMediaKeySystemAccess::requestMediaKeySystemAccess Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=476262:476271 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5298990191738880 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Jan 31 2018
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/64bff37c24aefed6abfc5066f8ff5c49e71072f7 (Ship WebUSB). If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
,
Jan 31 2018
It seems we are leaking the RenderMediaLog here: https://cs.chromium.org/chromium/src/content/renderer/media/media_factory.cc?rcl=715e4f97981a55b2983077649f4915125afdd628&l=347 It should be straightforward to fix. But today we only use it to report Rappor. Maybe we can just remove it? If not, we can let EncryptedMediaClient own a unique_ptr of the MediaLog instead of the raw pointer.
,
Jan 31 2018
,
Jan 31 2018
isherman: What's the rule on removing existing rappor metrics? I think we have those covered by UKM now.
,
Jan 31 2018
Steve knows more about RAPPOR than I do.
,
Feb 1 2018
If you don't need the data anymore, please do remove it (and mark it obsolete in rappor.xml).
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a76cad813b3da4bab7eba761985cc80571987032 commit a76cad813b3da4bab7eba761985cc80571987032 Author: Xiaohan Wang <xhwang@chromium.org> Date: Thu Feb 01 04:35:13 2018 media: Remove Rappor reporting in WebEncryptedMediaClientImpl Also remove MediaLog member in WebEncryptedMediaClientImpl since it's not needed anymore. This also fixes the memory leak of RenderMediaLog created. BUG= 807723 Change-Id: Ibe6dfc23964a0890147c2108e4bb4bd387e99f04 Reviewed-on: https://chromium-review.googlesource.com/896363 Reviewed-by: John Rummell <jrummell@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#533558} [modify] https://crrev.com/a76cad813b3da4bab7eba761985cc80571987032/content/renderer/media/media_factory.cc [modify] https://crrev.com/a76cad813b3da4bab7eba761985cc80571987032/media/blink/webencryptedmediaclient_impl.cc [modify] https://crrev.com/a76cad813b3da4bab7eba761985cc80571987032/media/blink/webencryptedmediaclient_impl.h [modify] https://crrev.com/a76cad813b3da4bab7eba761985cc80571987032/tools/metrics/rappor/rappor.xml
,
Feb 1 2018
ClusterFuzz has detected this issue as fixed in range 533557:533558. Detailed report: https://clusterfuzz.com/testcase?key=5298990191738880 Fuzzer: inferno_layout_test_unmodified Job Type: linux_lsan_chrome_mp Platform Id: linux Crash Type: Direct-leak Crash Address: Crash State: content::MediaFactory::EncryptedMediaClient blink::MediaKeysController::EncryptedMediaClient blink::NavigatorRequestMediaKeySystemAccess::requestMediaKeySystemAccess Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=476262:476271 Fixed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=533557:533558 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5298990191738880 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Feb 1 2018
ClusterFuzz testcase 5298990191738880 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ClusterFuzz
, Jan 31 2018Labels: Test-Predator-Auto-Components