New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807723 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Direct-leak in content::MediaFactory::EncryptedMediaClient

Project Member Reported by ClusterFuzz, Jan 31 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5298990191738880

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  content::MediaFactory::EncryptedMediaClient
  blink::MediaKeysController::EncryptedMediaClient
  blink::NavigatorRequestMediaKeySystemAccess::requestMediaKeySystemAccess
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=476262:476271

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5298990191738880

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 31 2018

Components: Internals>Media>Encrypted
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 31 2018

Labels: Test-Predator-Auto-Owner
Owner: reillyg@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/64bff37c24aefed6abfc5066f8ff5c49e71072f7 (Ship WebUSB).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by xhw...@chromium.org, Jan 31 2018

Cc: chcunningham@chromium.org jrumm...@chromium.org reillyg@chromium.org dalecur...@chromium.org
Labels: -Pri-2 M-66 Pri-1
Owner: xhw...@chromium.org
It seems we are leaking the RenderMediaLog here:

https://cs.chromium.org/chromium/src/content/renderer/media/media_factory.cc?rcl=715e4f97981a55b2983077649f4915125afdd628&l=347

It should be straightforward to fix. But today we only use it to report Rappor. Maybe we can just remove it? If not, we can let EncryptedMediaClient own a unique_ptr of the MediaLog instead of the raw pointer.

Comment 4 by xhw...@chromium.org, Jan 31 2018

Cc: -reillyg@chromium.org
Status: Started (was: Assigned)

Comment 5 by xhw...@chromium.org, Jan 31 2018

Cc: isherman@chromium.org
isherman: What's the rule on removing existing rappor metrics? I think we have those covered by UKM now.
Cc: -isherman@chromium.org holte@chromium.org
Steve knows more about RAPPOR than I do.

Comment 7 by holte@chromium.org, Feb 1 2018

If you don't need the data anymore, please do remove it (and mark it obsolete in rappor.xml).
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a76cad813b3da4bab7eba761985cc80571987032

commit a76cad813b3da4bab7eba761985cc80571987032
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Feb 01 04:35:13 2018

media: Remove Rappor reporting in WebEncryptedMediaClientImpl

Also remove MediaLog member in WebEncryptedMediaClientImpl since it's
not needed anymore.

This also fixes the memory leak of RenderMediaLog created.

BUG= 807723 

Change-Id: Ibe6dfc23964a0890147c2108e4bb4bd387e99f04
Reviewed-on: https://chromium-review.googlesource.com/896363
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533558}
[modify] https://crrev.com/a76cad813b3da4bab7eba761985cc80571987032/content/renderer/media/media_factory.cc
[modify] https://crrev.com/a76cad813b3da4bab7eba761985cc80571987032/media/blink/webencryptedmediaclient_impl.cc
[modify] https://crrev.com/a76cad813b3da4bab7eba761985cc80571987032/media/blink/webencryptedmediaclient_impl.h
[modify] https://crrev.com/a76cad813b3da4bab7eba761985cc80571987032/tools/metrics/rappor/rappor.xml

Project Member

Comment 9 by ClusterFuzz, Feb 1 2018

ClusterFuzz has detected this issue as fixed in range 533557:533558.

Detailed report: https://clusterfuzz.com/testcase?key=5298990191738880

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  content::MediaFactory::EncryptedMediaClient
  blink::MediaKeysController::EncryptedMediaClient
  blink::NavigatorRequestMediaKeySystemAccess::requestMediaKeySystemAccess
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=476262:476271
Fixed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=533557:533558

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5298990191738880

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Feb 1 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5298990191738880 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment