New issue
Advanced search Search tips

Issue 807720 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 678905



Sign in to add a comment

[WPT] service-workers/service-worker/local-url-inherit-controller.https.html fails

Project Member Reported by robertma@chromium.org, Jan 31 2018

Issue description

The test is recently introduced by Mozilla:
https://github.com/w3c/web-platform-tests/commits/master/service-workers/service-worker/local-url-inherit-controller.https.html

Imported at https://crrev.com/c/895662


external/wpt/service-workers/service-worker/local-url-inherit-controller.https.html [ Timeout ]
[ Linux Mac ] virtual/outofblink-cors/external/wpt/service-workers/service-worker/local-url-inherit-controller.https.html [ Timeout ]


(Manually filing the bug because import notifier was broken by a non-ASCII character in a subject line...  issue 807678 )
 
Blocking: 678905
Status: Available (was: Untriaged)
Thanks, I suspect the problem here is we don't support controlling data or blob URL clients.

Comment 2 by bke...@mozilla.com, Feb 2 2018

Note, the test tries to verify that data URL clients are not controlled since they get an opaque origin.  It seems like chrome should pass those.

I'm a bit surprised the test times out.  Maybe the local URL body for the frame:

const frameControllerText =
`<script>
  let t = navigator.serviceWorker.controller
        ? navigator.serviceWorker.controller.scriptURL
        : null;
  parent.postMessage({ data: t }, '*');
</` + `script>`;

Should have a try/catch so it can postMessage a failure on exception.  Something like:


const frameControllerText =
`<script>
  let t = null;
  try {
    if ( navigator.serviceWorker.controller) {
      t = navigator.serviceWorker.controller.scriptURL;
    }
  } catch (e) {
    t = e.message;
  } finally {
    parent.postMessage({ data: t }, '*');
  }
</` + `script>`
Interesting, thanks bkelly for pointing that out. Maybe it's not as a hard as I thought to get this test to work then.

Comment 4 by bke...@mozilla.com, Feb 2 2018

I think it was partly that, but also the Blob is not setting a mimetype which chrome seems to be more strict about.  I have a change that makes chrome not time out.  I'll file a WPT PR for you to review.

Comment 5 by bke...@mozilla.com, Feb 2 2018

https://github.com/w3c/web-platform-tests/pull/9365

Note, chrome mostly behaves as you would expect, but it *does* intercept a fetch() from a data URL iframe.  A bit surprising if it has an opaque origin.

Comment 6 by bke...@mozilla.com, Feb 2 2018

> Note, chrome mostly behaves as you would expect, but it *does* intercept a fetch() from a data URL iframe.  A bit surprising if it has an opaque origin.

Oh, sorry.  Its intercepting the fetch() in a data URL worker.  I assume thats because its being treated as a subresource instead of a non-subresource request.
bkelly: Thanks for fixing the timeout!
Summary: [WPT] service-workers/service-worker/local-url-inherit-controller.https.html fails (was: [WPT] service-workers/service-worker/local-url-inherit-controller.https.html times out)
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/631176ab167fc8575eaec2f21db6028718c7389a

commit 631176ab167fc8575eaec2f21db6028718c7389a
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Feb 06 06:56:17 2018

Gardening: local-url-inherit-controller.https.html no longer times out.

The time outs turned into assert failures in
https://github.com/w3c/web-platform-tests/pull/9365

TBR=shimazu

Bug: 807720
NOTRY: true
Change-Id: I1caba897521be0b87c4be03d403e88d62f6412de
Reviewed-on: https://chromium-review.googlesource.com/903026
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534647}
[modify] https://crrev.com/631176ab167fc8575eaec2f21db6028718c7389a/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment