New issue
Advanced search Search tips

Issue 807702 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

On Zero-Suggest, Titles Should Appear Before URLs

Project Member Reported by mpear...@chromium.org, Jan 31 2018

Issue description

Google Chrome	63.0.3239.132 (Official Build) (64-bit)
OS	Mac OS X

When the dropdown is opened on focus, on the list of suggestions, the title should appear before the URL.  This was already launched on all desktop platforms as part of the new zero-suggest suggestion system (ref bug 692471).  However, it was recently observed this isn't working on Mac.

 
Labels: -Pri-3 Pri-2
Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)
Assigning to tommycli, as he works in this area.

This behavior should've been enabled by the flag omnibox::kZeroSuggestSwapTitleAndUrl.

I have not checked more recent versions of Chrome on Mac.

Also, as it seems there's a chance we're converging on this behavior, I think zero suggest behavior should be tested as part of the test plan for bug 794203.
Cc: emilyschechter@chromium.org
ping tommycli@ - do you have an update on this?  I don't see it in the testing plan for  bug 794203.  Perhaps it should be there.  These on-focus suggestions are offered a lot, and having the titles and URLs swap during a single omnibox interaction maybe disruptive, even blocking for the title-first change.
I've never been able to trigger Zero Suggest on any platforms. I think I will need some help to repro and fix this bug.
Okay I got some extra instructions from Mark.

I just tested this on 66.0.3343.0, and it seems to work fine with the swap flag on. Attached is screenshot.

Perhaps accidentally fixed. Can anyone still repro this bug?
Screen Shot 2018-02-08 at 5.26.51 PM.png
556 KB View Download
How strange.

> I just tested this on 66.0.3343.0, and it seems to work fine with the
> swap flag on.
Switch swap flag?  kZeroSuggestSwapTitleAndUrl?

I believe I have that on because I'm in
OmniboxBundledExperimentV1-Stable_Desktop_OmniboxEntitySuggestions_Control, which has that on.

Google Chrome	64.0.3282.140 (Official Build) (64-bit)
Revision	a06bc1d5e8e285c70078802de990c1719ccc75e8-refs/branch-heads/3282@{#631}
OS	Mac OS X
JavaScript	V8 6.4.388.41

Variations	bd23585d-3f4a17df
c134752e-b8b72c88
59aeb88e-ca7d8d80
3095aa95-3f4a17df
d52c4ff7-ca7d8d80
47e5d3db-3d47f4f4
b1edbc38-c306c9a2
34d450b1-ca7d8d80
79616653-3f4a17df
57f575bb-3d47f4f4
d0ecf1da-12de74c0
f347910c-65bced95
4b61504a-d25ea691
9773d3bd-f23d1dea
8e3b2dc5-93702590
9e5c75f1-f359e04d
2981bcb4-ca7d8d80
f79cb77b-3f4a17df
4ea303a6-196db7ac
d92562a9-ca7d8d80
90bcbadc-3f4a17df
25fc488a-4d2fac87
58a025e3-c2b41702
1bced4a3-90fa85cd
b2f0086-93053e47
ef25c1eb-3f4a17df
2d871858-ca7d8d80
494d8760-6843eff2
f47ae82a-746c2ad4
3ac60855-3ec2a267
f296190c-f794ffd3
4442aae2-a90023b1
ed1d377-e1cc0f14
75f0f0a0-6bdfffe7
e2b18481-4c073154
e7e71889-e1cc0f14
34baa302-ae68ed72
f5fff3a2-ca7d8d80
94e68624-803f8fc4
f141d4bc-65bced95
da4aaa01-4d2fac87

zero suggest.png
119 KB View Download
tommycli@, I thought I saw a CL go by that should fix this, but I don't see it on this changelist.  What's the status of this bug?

Hi mpearson, the CL is here: https://chromium-review.googlesource.com/c/chromium/src/+/912101

It needs a bit more work right now because of a merge conflict that just happened.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cc7cdcbff6565eb6acbc8b69b81fba3ef792ef2

commit 4cc7cdcbff6565eb6acbc8b69b81fba3ef792ef2
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Feb 16 14:31:35 2018

Omnibox UI: Clean up title and contents swapping behavior

This CL:
 1. Refactors AutocompleteMatch so that we can't accidentally swap the
    contents and description of matches stored in the model code.

 2. Consolidates some swapping behavior living in the UI code in with
    the rest of the swapping behavior.

 3. Fixes ZeroSuggest swapped title and description for Cocoa.

Bug:  807702 
Change-Id: Ibb17860122a52a9fba7df707ab2c18ac327297ac
Reviewed-on: https://chromium-review.googlesource.com/912101
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537302}
[modify] https://crrev.com/4cc7cdcbff6565eb6acbc8b69b81fba3ef792ef2/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
[modify] https://crrev.com/4cc7cdcbff6565eb6acbc8b69b81fba3ef792ef2/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm
[modify] https://crrev.com/4cc7cdcbff6565eb6acbc8b69b81fba3ef792ef2/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/4cc7cdcbff6565eb6acbc8b69b81fba3ef792ef2/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/4cc7cdcbff6565eb6acbc8b69b81fba3ef792ef2/components/omnibox/browser/autocomplete_match.h
[modify] https://crrev.com/4cc7cdcbff6565eb6acbc8b69b81fba3ef792ef2/components/omnibox/browser/omnibox_field_trial.cc

Status: Fixed (was: Assigned)
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
tommycli@ Could you please help us with repro steps to verify this Fix from TE-End ? 
1. Run chrome with --enable-features=ZeroSuggestSwapTitleAndUrl.
2. Make sure you are Signed into chrome and syncing.
3. Visit https://www.nytimes.com/.
4. Trigger ZeroSuggest by clicking the Omnibox. A list of suggestions should drop down before the user has begun typing anything.
5. Verify titles are shown before the URLs.

Sign in to add a comment