New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807691 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Hotlist-1


Sign in to add a comment

[Autotest] hardware_memoryqual doesn't process suite_args properly.

Project Member Reported by sidal@chromium.org, Jan 31 2018

Issue description

Autotest Suite hardware_memoryqual doesn't process suite_args properly.

Currently, the control file of hardware_memoryqual suite treat suite_args as a python dictionary. However, it may be a string representing a dictionary in newer moblab releases.

Error log:
Traceback (most recent call last):
  File "/usr/local/autotest/server/server_job.py", line 856, in run
    self._execute_code(server_control_file, namespace)
  File "/usr/local/autotest/server/server_job.py", line 1357, in _execute_code
    execfile(code_file, namespace, namespace)
  File "/usr/local/autotest/results/2-moblab/hostless/control.srv", line 69, in <module>
    avl_keyval['bug_id'] = suite_args.get("bug_id", "")
AttributeError: 'str' object has no attribute 'get'
 
Labels: -Merge-Request-65 Merge-Approved-65
If this is for https://chromium-review.googlesource.com/#/c/chromiumos/third_party/autotest/+/895183/ once it merges into ToT, consider it merge approved for 65. 

Comment 2 by sidal@chromium.org, Jan 31 2018

Suite_args is injected into control file as a string type in M64 and will be passed in as a dict type in M65. Additional logic is added when suite_args is a string.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 1 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7f8f017d58b2b61cc5a0fd4ea6b67edc9502470a

commit 7f8f017d58b2b61cc5a0fd4ea6b67edc9502470a
Author: Sida Liu <sidal@chromium.org>
Date: Thu Feb 01 00:14:41 2018

[autotest] Fix control file of memqual autotest suite control file.

Retrieve bug_id and part_id for the memqual autotest from args_dict
directly since suite_args is merged into args_dict.

BUG= chromium:807691 
TEST=Manual test
Change-Id: I2c18bd66a10182c3c54f737a674e0752fe183acc
Reviewed-on: https://chromium-review.googlesource.com/895400
Reviewed-by: Sida Liu <sidal@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Sida Liu <sidal@chromium.org>
Tested-by: Sida Liu <sidal@chromium.org>

[modify] https://crrev.com/7f8f017d58b2b61cc5a0fd4ea6b67edc9502470a/test_suites/control.hardware_memoryqual

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7d0df5f1d278acf0830b7b3cfad595e8be73070e

commit 7d0df5f1d278acf0830b7b3cfad595e8be73070e
Author: Sida Liu <sidal@chromium.org>
Date: Thu Feb 01 02:01:03 2018

[autotest] Fix control file of memqual autotest suite control file.

Retrieve bug_id and part_id for the memqual autotest from args_dict
directly since suite_args is merged into args_dict.

BUG= chromium:807691 
TEST=Manual test
Change-Id: I2c18bd66a10182c3c54f737a674e0752fe183acc
Reviewed-on: https://chromium-review.googlesource.com/895183
Commit-Ready: Sida Liu <sidal@chromium.org>
Tested-by: Sida Liu <sidal@chromium.org>
Reviewed-by: Sida Liu <sidal@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/7d0df5f1d278acf0830b7b3cfad595e8be73070e/test_suites/control.hardware_memoryqual

Comment 6 by sidal@chromium.org, Feb 6 2018

Labels: -M-65 M-64
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 6 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by sidal@chromium.org, Feb 7 2018

This bug is related to hardware_memoryqual autotest sutie. It does not affect production images. Only test images will be affected.

The control file of the hardware_memoryqual autotest suite used to extract part_id and bug_id from variable suite_args, which are merged into variable args_dict now.

This change list fixes the bug:
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/905340

The hardware_memoryqual autotest suite is only used by partners to test memory components during the memory AVL process. Partners are expected to run the hardware_memoryqual autotest suite with a moblab on M64/M63. Manual testing has been done to make sure it works with moblab on both M64 and M63.

Labels: -Merge-Review-64 Merge-Approved-64
Thanks for the clarification in #8.   Approving for M64.
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 8 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/561e7af94d50f1d300e7bca6822c97354dad3224

commit 561e7af94d50f1d300e7bca6822c97354dad3224
Author: Sida Liu <sidal@chromium.org>
Date: Thu Feb 08 17:32:01 2018

[autotest] Fix control file of memqual autotest suite control file.

Retrieve bug_id and part_id for the memqual autotest from args_dict
directly since suite_args is merged into args_dict.

BUG= chromium:807691 
TEST=Manual test
Change-Id: I2c18bd66a10182c3c54f737a674e0752fe183acc
Reviewed-on: https://chromium-review.googlesource.com/895400
Reviewed-by: Sida Liu <sidal@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Sida Liu <sidal@chromium.org>
Tested-by: Sida Liu <sidal@chromium.org>
(cherry picked from commit 7f8f017d58b2b61cc5a0fd4ea6b67edc9502470a)
Reviewed-on: https://chromium-review.googlesource.com/905340

[modify] https://crrev.com/561e7af94d50f1d300e7bca6822c97354dad3224/test_suites/control.hardware_memoryqual

Project Member

Comment 11 by sheriffbot@chromium.org, Feb 12 2018

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 16 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by sidal@chromium.org, Mar 12 2018

Status: Verified (was: Started)

Sign in to add a comment