New issue
Advanced search Search tips

Issue 807682 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: store as global variable is slow/not immediate

Project Member Reported by l...@chromium.org, Jan 31 2018 
OS: all

What steps will reproduce the problem?
(1) Log an object in the DevTools console (e.g. `console.log(window)`)
(2) Right click the object and click 'Store as global variable'
(3) Wait for a 'temp1' to be evaluated in console

What is the expected result?
'temp1' should always appear with its value below quickly

What happens instead?
Intermittent, but sometimes no new console message will appear without moving the mouse/clicking/new message arriving.

It is highly likely that the evaluated 'temp1' is received by DevTools but the viewport is muted when it arrives (see _muteViewportUpdates flag in ConsoleView.js)
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e4850aa00809107324b200f13da152eedda50ea

commit 2e4850aa00809107324b200f13da152eedda50ea
Author: Erik Luo <luoe@chromium.org>
Date: Sat Jun 09 01:34:01 2018

DevTools: fix muted 'Store as global variable' in console

Console assumes that every 'mousedown' event is followed by either a
'mouseup' or 'mouseleave' event. This key assumption allows muting
viewport updates for scrollbar dragging, wheel-up-from-bottom, and
pageUp events.

This assumption is false for right clicks that: occur too rapidly or
mouseup outside the window. This CL prevents viewport muting on
right clicks.

Screenshot of bug: https://imgur.com/a/iC2lkgU

Bug:  807682 
Change-Id: I2bb4f103eadc28950968c451b80e3186733e32ce
Reviewed-on: https://chromium-review.googlesource.com/917982
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565812}
[modify] https://crrev.com/2e4850aa00809107324b200f13da152eedda50ea/third_party/blink/renderer/devtools/front_end/console/ConsoleView.js

Comment 2 by l...@chromium.org, Jun 14 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment