Currently the naming of Animation related classes on cc side is very confusing. e.g. cc::Animation is totally different from blink::Animation. We should update the names so that they could match their blink counterparts which are based on the spec.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3904dc2ec06653b0b7281580c6d1662aeb9d87e0 commit 3904dc2ec06653b0b7281580c6d1662aeb9d87e0 Author: Yi Gu <yigu@chromium.org> Date: Thu Feb 15 18:35:24 2018 Rename cc animation classes to be consistent with blink classes and spec Currently the names of Animation related classes on cc side is very confusing. e.g. cc::Animation is quite different from blink::Animation. blink::Animation is corresponding to cc::AnimationPlayer which owns multiple cc::AnimationTicker which owns multiple cc::Animation. To be consistent with blink, it’s better to rename the relevant classes. In addition, the cc::AnimationTicker behaves as the cc counterpart of blink::KeyframeEffect therefore it should be renamed as well. Corresponding changes are also made to the clients of cc::Animation (vr, ui, blink) in this patch. Summary: This patch: Animation -> KeyframeModel AnimationTicker -> KeyframeEffect Follow up patch: AnimationPlayer -> Animation Bug: 807667 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I24c240b514da38541e4dd8a5550a9092ebd11430 Reviewed-on: https://chromium-review.googlesource.com/906830 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#537082} [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/BUILD.gn [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/README.md [delete] https://crrev.com/302248e53cce2aca152b0987f16248900d07f9a6/cc/animation/animation.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_delegate.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_events.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_host.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_host.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_host_perftest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_id_provider.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_id_provider.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_player.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_player.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_player_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_target.h [delete] https://crrev.com/302248e53cce2aca152b0987f16248900d07f9a6/cc/animation/animation_ticker.cc [delete] https://crrev.com/302248e53cce2aca152b0987f16248900d07f9a6/cc/animation/animation_ticker.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_timeline_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/animation_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/element_animations.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/element_animations.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/element_animations_unittest.cc [add] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/keyframe_effect.cc [add] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/keyframe_effect.h [rename] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/keyframe_model.cc [add] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/keyframe_model.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/scroll_offset_animations_impl.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/scroll_offset_animations_impl.h [add] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/single_keyframe_effect_animation_player.cc [add] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/single_keyframe_effect_animation_player.h [delete] https://crrev.com/302248e53cce2aca152b0987f16248900d07f9a6/cc/animation/single_ticker_animation_player.cc [delete] https://crrev.com/302248e53cce2aca152b0987f16248900d07f9a6/cc/animation/single_ticker_animation_player.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/worklet_animation_player.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/worklet_animation_player.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/animation/worklet_animation_player_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/layers/layer.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/layers/layer_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/test/animation_test_common.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/test/animation_test_common.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/test/animation_timelines_test_common.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/test/animation_timelines_test_common.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/test/layer_tree_test.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/test/layer_tree_test.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/trees/layer_tree_host.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/cc/trees/mutator_host.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/animation_player.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/animation_player.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/animation_player_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/button.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/button.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/disc_button.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/disc_button.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/environment/background.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/environment/background.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/environment/grid.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/environment/grid.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/keyboard.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/keyboard.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/rect.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/rect.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/spinner.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/spinner.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/throbber.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/throbber.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/toast.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/toast.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/elements/ui_element_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/test/animation_utils.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/test/animation_utils.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/chrome/browser/vr/ui_scene_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/core/animation/CompositorAnimations.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/core/animation/Timing.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/core/paint/LinkHighlightImpl.cpp [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/BUILD.gn [delete] https://crrev.com/302248e53cce2aca152b0987f16248900d07f9a6/third_party/WebKit/Source/platform/animation/CompositorAnimation.cpp [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/animation/CompositorAnimationDelegate.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayerTest.cpp [delete] https://crrev.com/302248e53cce2aca152b0987f16248900d07f9a6/third_party/WebKit/Source/platform/animation/CompositorAnimationTest.cpp [add] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/animation/CompositorKeyframeModel.cpp [rename] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/animation/CompositorKeyframeModel.h [add] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/animation/CompositorKeyframeModelTest.cpp [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/ui/compositor/layer_animation_element.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/ui/compositor/layer_animation_element.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/ui/compositor/layer_animation_element_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/ui/compositor/layer_animation_sequence_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/ui/compositor/layer_animator.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/ui/compositor/layer_animator.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/ui/compositor/layer_owner_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/ui/compositor/layer_threaded_animation_delegate.h [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/ui/compositor/layer_unittest.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/ui/compositor/test/test_layer_animation_delegate.cc [modify] https://crrev.com/3904dc2ec06653b0b7281580c6d1662aeb9d87e0/ui/compositor/test/test_layer_animation_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1fe8593ec7f546256287c6d5743909e1298c32d commit f1fe8593ec7f546256287c6d5743909e1298c32d Author: Yi Gu <yigu@chromium.org> Date: Fri Feb 16 04:33:58 2018 Rename variables that were missed from the previous renaming patch In patch https://chromium-review.googlesource.com/906830 we renamed cc side animation related classes but there are some variables missing, e.g. animation_id instead of keyframe_model_id. This should be fixed before next patch which will rename AnimationPlayer to Animation so that it won't conflict with the new "animation_id". Bug: 807667 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id5a8d07a7e551fff78b746728fce3dd139bb5b21 Reviewed-on: https://chromium-review.googlesource.com/922342 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537199} [modify] https://crrev.com/f1fe8593ec7f546256287c6d5743909e1298c32d/cc/animation/animation_player.cc [modify] https://crrev.com/f1fe8593ec7f546256287c6d5743909e1298c32d/cc/animation/animation_player.h [modify] https://crrev.com/f1fe8593ec7f546256287c6d5743909e1298c32d/cc/animation/element_animations_unittest.cc [modify] https://crrev.com/f1fe8593ec7f546256287c6d5743909e1298c32d/cc/animation/keyframe_effect.h [modify] https://crrev.com/f1fe8593ec7f546256287c6d5743909e1298c32d/cc/animation/single_keyframe_effect_animation_player.cc [modify] https://crrev.com/f1fe8593ec7f546256287c6d5743909e1298c32d/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/f1fe8593ec7f546256287c6d5743909e1298c32d/third_party/WebKit/Source/platform/animation/CompositorKeyframeModel.h [modify] https://crrev.com/f1fe8593ec7f546256287c6d5743909e1298c32d/ui/compositor/test/test_layer_animation_delegate.cc [modify] https://crrev.com/f1fe8593ec7f546256287c6d5743909e1298c32d/ui/compositor/test/test_layer_animation_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c76aeb0164cee1a21eccf80c222322b190d1000 commit 0c76aeb0164cee1a21eccf80c222322b190d1000 Author: Yi Gu <yigu@chromium.org> Date: Fri Feb 16 19:27:59 2018 Rename animation_unittest.cc to keyframe_model_unittest.cc In patch https://chromium-review.googlesource.com/906830 we renamed cc side animation related classes but it missed a test file listed in the subject. It should be fixed prior to next renaming patch. Bug: 807667 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib8c86a9f28b12b6a298f5d284c7ceb7171db1958 Reviewed-on: https://chromium-review.googlesource.com/924172 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537377} [modify] https://crrev.com/0c76aeb0164cee1a21eccf80c222322b190d1000/cc/BUILD.gn [delete] https://crrev.com/030e252e81d5a50d3f0ca5562a61c17b5a3b27fd/cc/animation/animation_unittest.cc [add] https://crrev.com/0c76aeb0164cee1a21eccf80c222322b190d1000/cc/animation/keyframe_model_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa830ff57ef82d5f773a75e38012a516daffe81c commit aa830ff57ef82d5f773a75e38012a516daffe81c Author: Yi Gu <yigu@chromium.org> Date: Thu Feb 22 03:09:11 2018 Rename AnimationPlayer to Animation in cc and all its clients This patch updates the name cc::AnimationPlayer to cc::Animation so that it will be consistent with the blink::Animation. It's a follow-up patch of https://chromium-review.googlesource.com/c/chromium/src/+/906830. Other clients of cc::Animation (vr, ui) have been updated accordingly. Bug: 807667 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If80affe7bedf46ae8f0356a6fa8a89e2f1d81973 Reviewed-on: https://chromium-review.googlesource.com/926901 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#538327} [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/BUILD.gn [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/BUILD.gn [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/README.md [rename] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation.cc [rename] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation_delegate.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation_host.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation_host.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation_host_perftest.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation_host_unittest.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation_id_provider.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation_id_provider.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation_player_unittest.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation_timeline.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation_timeline.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/animation_timeline_unittest.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/element_animations_unittest.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/keyframe_effect.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/keyframe_effect.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/keyframe_model.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/scroll_offset_animation_curve.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/scroll_offset_animations_impl.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/scroll_offset_animations_impl.h [add] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/single_keyframe_effect_animation.cc [add] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/single_keyframe_effect_animation.h [delete] https://crrev.com/e7220751085e18360ce44dc0ae3645c55f926f47/cc/animation/single_keyframe_effect_animation_player.cc [delete] https://crrev.com/e7220751085e18360ce44dc0ae3645c55f926f47/cc/animation/single_keyframe_effect_animation_player.h [add] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/worklet_animation.cc [add] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/worklet_animation.h [delete] https://crrev.com/e7220751085e18360ce44dc0ae3645c55f926f47/cc/animation/worklet_animation_player.cc [delete] https://crrev.com/e7220751085e18360ce44dc0ae3645c55f926f47/cc/animation/worklet_animation_player.h [rename] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/animation/worklet_animation_unittest.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/layers/layer_unittest.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/test/animation_test_common.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/test/animation_test_common.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/test/animation_timelines_test_common.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/test/animation_timelines_test_common.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/test/layer_test_common.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/test/layer_tree_test.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/test/layer_tree_test.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/cc/trees/layer_tree_mutator.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/BUILD.gn [rename] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/animation.cc [rename] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/animation.h [delete] https://crrev.com/e7220751085e18360ce44dc0ae3645c55f926f47/chrome/browser/vr/animation_player_unittest.cc [add] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/animation_unittest.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/elements/environment/background.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/elements/environment/grid.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/elements/rect.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/elements/spinner.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/elements/throbber.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/chrome/browser/vr/test/animation_utils.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/core/animation/Animation.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/core/animation/Animation.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/core/animation/CompositorAnimations.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/core/events/event_target_names.json5 [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/core/paint/LinkHighlightImpl.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/core/paint/LinkHighlightImpl.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScope.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScope.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScopeTest.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/BUILD.gn [add] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/animation/CompositorAnimation.cpp [rename] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/animation/CompositorAnimation.h [add] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/animation/CompositorAnimationClient.cpp [add] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/animation/CompositorAnimationClient.h [delete] https://crrev.com/e7220751085e18360ce44dc0ae3645c55f926f47/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp [delete] https://crrev.com/e7220751085e18360ce44dc0ae3645c55f926f47/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayerClient.cpp [delete] https://crrev.com/e7220751085e18360ce44dc0ae3645c55f926f47/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayerClient.h [delete] https://crrev.com/e7220751085e18360ce44dc0ae3645c55f926f47/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayerTest.cpp [add] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/animation/CompositorAnimationTest.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/animation/CompositorAnimationTimelineTest.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/ui/compositor/layer_animator.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/ui/compositor/layer_animator.h [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/ui/compositor/layer_owner_unittest.cc [modify] https://crrev.com/aa830ff57ef82d5f773a75e38012a516daffe81c/ui/compositor/layer_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/852bebe63b58a3761bec0ec30023296b6a1297e7 commit 852bebe63b58a3761bec0ec30023296b6a1297e7 Author: Yi Gu <yigu@chromium.org> Date: Fri Mar 02 15:15:32 2018 Clean up remaining issues from the renaming patch Rename animation_player_unittest.cc to animation_unittest.cc Bug: 807667 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9e15c5275330c06516c13ab55f41d4f97802bfd7 Reviewed-on: https://chromium-review.googlesource.com/945409 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540520} [modify] https://crrev.com/852bebe63b58a3761bec0ec30023296b6a1297e7/cc/BUILD.gn [modify] https://crrev.com/852bebe63b58a3761bec0ec30023296b6a1297e7/cc/animation/animation_host.cc [rename] https://crrev.com/852bebe63b58a3761bec0ec30023296b6a1297e7/cc/animation/animation_unittest.cc
Issue 651692 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c66f9a0f5857a4054bf6c296c7a0ff8d5594304a commit c66f9a0f5857a4054bf6c296c7a0ff8d5594304a Author: Yi Gu <yigu@chromium.org> Date: Wed Jun 13 21:48:33 2018 Rename compositor_animation_id to compositor_keyframe_model_id to eliminate misleadings Upon posting removing keyframe models events from main we are using the name compositor_animation_ids_ which is misleading. This is a remaining issue from the renaming patch we had before. Bug: 807667 Change-Id: I985fff4d5073b69e8f3637b6273a6c72b7884e83 Reviewed-on: https://chromium-review.googlesource.com/1097582 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567004} [modify] https://crrev.com/c66f9a0f5857a4054bf6c296c7a0ff8d5594304a/third_party/blink/renderer/core/animation/compositor_animations.cc [modify] https://crrev.com/c66f9a0f5857a4054bf6c296c7a0ff8d5594304a/third_party/blink/renderer/core/animation/compositor_animations.h [modify] https://crrev.com/c66f9a0f5857a4054bf6c296c7a0ff8d5594304a/third_party/blink/renderer/core/animation/compositor_animations_test.cc [modify] https://crrev.com/c66f9a0f5857a4054bf6c296c7a0ff8d5594304a/third_party/blink/renderer/core/animation/keyframe_effect.cc [modify] https://crrev.com/c66f9a0f5857a4054bf6c296c7a0ff8d5594304a/third_party/blink/renderer/core/animation/keyframe_effect.h
Comment 1 by bugdroid1@chromium.org
, Feb 15 2018