No "Next" link for recent builds for luci.chromium.* builders |
|||||
Issue descriptionMilo has a Next link that links to build history w/ a cursor; this link isn't present for luci builds. to wit: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit?limit=200 vs https://ci.chromium.org/buildbot/tryserver.chromium.linux/chromium_presubmit/?limit=200
,
Jan 31 2018
,
Feb 28 2018
,
May 18 2018
bump ... as me migrate more builders to LUCI, this'll get increasingly annoying. Having fast, indefinite scrollback for builds in Milo is *really* useful. Can we prioritize getting this?
,
May 18 2018
There are a couple ways to do this that I can think of: * Use a datastore cursor * Use a timestamp * Use the buildbucket build id, which I believe have an inherent ordering
,
May 18 2018
this data is coming directly from bulidbucket. I think buildbucket-provided cursor should be used
,
May 18 2018
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/fda1fad1b1e0f23c3e83d20999217eea7bbb771c commit fda1fad1b1e0f23c3e83d20999217eea7bbb771c Author: Ryan Tseng <hinoka@google.com> Date: Fri May 25 23:19:03 2018 [milo] Add paging support for luci builders Adapted from luci-scheduler (go.chromium.org/luci/scheduler/appengine/ui/job.go:jobPage()) Bug: 807649 Change-Id: I66e827859770687d086b2c0a2ad8527f06d1f987 Reviewed-on: https://chromium-review.googlesource.com/1066678 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/fda1fad1b1e0f23c3e83d20999217eea7bbb771c/common/api/buildbucket/buildbucket/v1/address.go [modify] https://crrev.com/fda1fad1b1e0f23c3e83d20999217eea7bbb771c/common/api/buildbucket/buildbucket/v1/search.go [modify] https://crrev.com/fda1fad1b1e0f23c3e83d20999217eea7bbb771c/common/api/buildbucket/buildbucket/v1/search_test.go [modify] https://crrev.com/fda1fad1b1e0f23c3e83d20999217eea7bbb771c/milo/buildsource/buildbot/buildstore/build.go [modify] https://crrev.com/fda1fad1b1e0f23c3e83d20999217eea7bbb771c/milo/buildsource/buildbot/buildstore/query.go [modify] https://crrev.com/fda1fad1b1e0f23c3e83d20999217eea7bbb771c/milo/buildsource/buildbucket/builder.go [modify] https://crrev.com/fda1fad1b1e0f23c3e83d20999217eea7bbb771c/milo/buildsource/buildbucket/builder_test.go [modify] https://crrev.com/fda1fad1b1e0f23c3e83d20999217eea7bbb771c/milo/buildsource/builder.go |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by no...@chromium.org
, Jan 31 2018Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)