New issue
Advanced search Search tips

Issue 807647 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Clank omnibox briefly shows up in-texture when entering VR

Project Member Reported by mthiesse@chromium.org, Jan 31 2018

Issue description

1. Enter VR from any 2D site.
2. See distorted omnibox texture.
3. Omnibox texture goes away after ~100ms


Related to  issue 806004 ?
 
Pretty sure this is a regression, but I haven't bisected.
Summary: VR: Clank omnibox briefly shows up in-texture when entering VR (was: VR: Omnibox briefly shows up in-texture when entering VR)
Owner: mthiesse@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc06748f65cc2b14d93488b89300068242a7f459

commit fc06748f65cc2b14d93488b89300068242a7f459
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Feb 23 17:23:29 2018

VR: Wait until compositor receives an omnibox-less frame to render content.

The first few frames received after entering VR could still contain the
browser-compositor-drawn omnibox texture, so we have to wait until we get a
frame without that (using the content offset as a proxy to know when the
omnibox is gone).

Bug:  807647 
Change-Id: Ib9119aacaefe653c09c80da553305e79d14a2413
Reviewed-on: https://chromium-review.googlesource.com/934404
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538813}
[modify] https://crrev.com/fc06748f65cc2b14d93488b89300068242a7f459/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
[modify] https://crrev.com/fc06748f65cc2b14d93488b89300068242a7f459/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/fc06748f65cc2b14d93488b89300068242a7f459/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/fc06748f65cc2b14d93488b89300068242a7f459/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/fc06748f65cc2b14d93488b89300068242a7f459/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/fc06748f65cc2b14d93488b89300068242a7f459/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/fc06748f65cc2b14d93488b89300068242a7f459/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/fc06748f65cc2b14d93488b89300068242a7f459/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/fc06748f65cc2b14d93488b89300068242a7f459/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/fc06748f65cc2b14d93488b89300068242a7f459/chrome/browser/android/vr_shell/vr_shell_gl.h

Status: Fixed (was: Started)
Labels: Test-Complete

Sign in to add a comment