New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807641 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Jan 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocked on:
issue 794210

Blocking:
issue 787005



Sign in to add a comment

Load the support library from //third_party/android_deps

Project Member Reported by dgn@chromium.org, Jan 31 2018

Issue description

As proof of concept for the dependency process from issue 794210, we want to start updating and loading the support library via android_deps. As the support library is used in a lot of libraries, it will also be needed for Dagger, so that's also an initial step for issue 787005


# Support Lib declaration cleanup

A side effect of the android_deps migration is that the visibility of transitive dependencies will become restricted. We currently declare com.android.support:appcompat-v4 and com.android.support:appcompat-v7 as dependencies, but not some lower level dependencies that get transitively downloaded like fragment-compat. As a result they will become hidden and unusable in other targets. We currently already pull these libraries trough umbrella targets for v4 and v7, but still explicitly list the transitive dependencies. These will need to be cleaned up as they are redundant now and will break in the future.

# Migration details

The dependencies will be available for some time from both android_deps and the current android_tools/sdk.. location, with a GN flag used to switch between them, and will eventually get cleaned up once regression and breakage risks are cleared.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/f389f8ab238a7a51e6cfa6c362912a73a3dcf935

commit f389f8ab238a7a51e6cfa6c362912a73a3dcf935
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Wed Jan 31 17:38:53 2018

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/855e8413c8ff573eef5d6f7416040d9499af34c6

commit 855e8413c8ff573eef5d6f7416040d9499af34c6
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Thu Feb 01 15:21:02 2018

🔧 Cleanup redundant support lib targets

Removes unnecessary support library target aliases and their
usage.

Bug:  807641 
Change-Id: I957d0490eedd4202a3f460469bb2b37771fafbcc
Reviewed-on: https://chromium-review.googlesource.com/895450
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533668}
[modify] https://crrev.com/855e8413c8ff573eef5d6f7416040d9499af34c6/build/secondary/third_party/android_tools/BUILD.gn
[modify] https://crrev.com/855e8413c8ff573eef5d6f7416040d9499af34c6/build/secondary/third_party/android_tools/support/BUILD.gn
[modify] https://crrev.com/855e8413c8ff573eef5d6f7416040d9499af34c6/remoting/android/client_java_tmpl.gni

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23608875c5be292672154ad564bfb53f2de788b6

commit 23608875c5be292672154ad564bfb53f2de788b6
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Fri Feb 02 11:56:23 2018

🔧 Add GN flag to switch the source of the support lib

Setting enable_android_deps_repository to true will let the build
use the dependencies defined in //third_party/android_deps, that will
be added by https://crrev.com/c/819771.
By default this flag is disabled.

Bug:  807641 
Change-Id: If75f7bbac38d2dc807ae35cdd8de0f229bcf6545
Reviewed-on: https://chromium-review.googlesource.com/895691
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534024}
[modify] https://crrev.com/23608875c5be292672154ad564bfb53f2de788b6/build/config/android/config.gni
[modify] https://crrev.com/23608875c5be292672154ad564bfb53f2de788b6/build/config/android/rules.gni
[modify] https://crrev.com/23608875c5be292672154ad564bfb53f2de788b6/build/secondary/third_party/android_tools/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment