New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807628 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in content::QuotaDispatcherHost::QueryStorageUsageAndQuota

Project Member Reported by ClusterFuzz, Jan 31 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5499110166364160

Fuzzer: inferno_twister
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  content::QuotaDispatcherHost::QueryStorageUsageAndQuota
  blink::mojom::QuotaDispatcherHostStubDispatch::AcceptWithResponder
  blink::mojom::QuotaDispatcherHostStub<mojo::RawPtrImplRefTraits<blink::mojom::Qu
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=521894:521922

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5499110166364160

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 31 2018

Labels: Test-Predator-Auto-Owner
Owner: sashab@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/167850c4880f37ea60f0409c21048bee44548dae (Remove subclasses and outstanding_requests_ from QuotaDispatcherHost).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Components: Blink>Internals>Modularization Blink>Storage>Quota
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 1 2018

Labels: M-65
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 1 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 1 2018

Labels: Pri-1
Cc: sa...@chromium.org
+sammc any ideas? >.<
I think https://chromium-review.googlesource.com/c/chromium/src/+/895230 might have fixed it. Can't build it on my version of Linux; I get the error:
Exception: ('Supported Ubuntu versions: %s', "['trusty']")
Status: Fixed (was: Assigned)
Project Member

Comment 9 by ClusterFuzz, Feb 2 2018

ClusterFuzz has detected this issue as fixed in range 533887:533898.

Detailed report: https://clusterfuzz.com/testcase?key=5499110166364160

Fuzzer: inferno_twister
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  content::QuotaDispatcherHost::QueryStorageUsageAndQuota
  blink::mojom::QuotaDispatcherHostStubDispatch::AcceptWithResponder
  blink::mojom::QuotaDispatcherHostStub<mojo::RawPtrImplRefTraits<blink::mojom::Qu
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=521894:521922
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=533887:533898

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5499110166364160

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Feb 2 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5499110166364160 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Feb 4 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Request-65
The change listed in #7 is indeed in the fixed range in #9.
Project Member

Comment 13 by sheriffbot@chromium.org, Feb 13 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
awhalley@, is this good to take it in for M65?
Cc: awhalley@chromium.org
Labels: -Merge-Review-65 Merge-Approved-65
Approving merge to M65 branch 3325 per comment #12 and offline chat with awhalley@. Pls merge ASAP so we can pick it up for this week Beta release. Thank you.
Pls merge your change to M65 branch ASAP. Thank you.
Merged in https://chromium-review.googlesource.com/c/chromium/src/+/920962

Sorry about the delay, thank you.
Labels: -Merge-Approved-65 merge-merged-3325
Per comment #18, this is already merge to M65. Thank you & no worries.
Labels: -ReleaseBlock-Stable
Project Member

Comment 21 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Stable
Labels: Release-0-M66
Project Member

Comment 23 by sheriffbot@chromium.org, May 11 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment