Are you sure they're getting emitted correctly? You won't see them listed if we get 0 data on it.

Can you confirm you see an example histogram in chrome://histograms?

I do see them locally in Canary in chrome://histograms. And even with zero
data usually the dashboard would show "No Data", right?

Le mer. 31 janv. 2018 16 h 24, rkaplow via monorail <
monorail+v2.1469547171@chromium.org> a écrit :

I think the issue is that the TaskSchedulerTaskType suffixes are missing the .Browser version of the histogram – only .Renderer is listed.

No, that's the thing... It is there Browser,Renderer,ContentChild are all under the TaskSchedulerName suffix in histograms.xml :

https://cs.chromium.org/chromium/src/tools/metrics/histograms/histograms.xml?q=%5C"TaskSchedulerName%5C"&sq=package:chromium&maxsize=8392168

Gab, you linked to a line that reads "<suffix base="true" name="Browser" ...>".  The base="true" means that a suffix should further complete the histogram name.  Which suffix are you expecting to do so?

.Browser is intended as a base suffix, he expects it to be completed like:
TaskScheduler.TaskLatencyMicroseconds.Renderer.UserVisibleTaskPriority
(as per his example)

I think what's missing is here:
https://codesearch.chromium.org/chromium/src/tools/metrics/histograms/histograms.xml?q=TaskScheduler.TaskLatencyMicroseconds.Renderer&sq=package:chromium&maxsize=8394192&l=112475

that has .Renderer as a suffix, but is missing Browser there

Ah... you're right, stacking suffixes gets hard to configure quickly... filed  issue 808383  for you to consider a better scheme.

In the mean time, I think https://chromium-review.googlesource.com/#/c/chromium/src/+/899002 fixes this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b1135ae1e0bc9cb0355d64e9a489f3ad450231f

commit 8b1135ae1e0bc9cb0355d64e9a489f3ad450231f
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Feb 02 19:21:40 2018

Fix TaskScheduler histogram suffixes some more.

R=rkaplow@chromium.org

Bug:  807616 
Change-Id: I924535fdb39c35c6fe949f82753413505bd65057
Reviewed-on: https://chromium-review.googlesource.com/899002
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534118}
[modify] https://crrev.com/8b1135ae1e0bc9cb0355d64e9a489f3ad450231f/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc2d94e3a5b128a5d206423d7ae7873232ed490c

commit bc2d94e3a5b128a5d206423d7ae7873232ed490c
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Feb 05 15:29:47 2018

Remove plain TaskScheduler.TaskLatencyMicroseconds from TaskSchedulerTaskType's affected histograms.

It seems the <obsolete> tag isn't supported on the <affected-histogram>
tag? TaskScheduler.TaskLatencyMicroseconds.* still lists these on the
dashboard.

Those existed very shortly (between two CLs), dropping them from
existence if fine IMO.

R=rkaplow@chromium.org

Bug:  807616 
Change-Id: Idb58204230acddcbbba1d9f9344d51cde33d3147
Reviewed-on: https://chromium-review.googlesource.com/901244
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534387}
[modify] https://crrev.com/bc2d94e3a5b128a5d206423d7ae7873232ed490c/tools/metrics/histograms/histograms.xml