Regression:Password bubble does not appear in gmail.com after login
Reported by
shruti.j...@etouch.net,
Jan 31 2018
|
||||||||||
Issue descriptionChrome Version: 66.0.3335.0 (Official Build) (64-bit) (cohort: 64_119_win) 94092b8f650d5552ed3595eb2b3a0a96488524e7-refs/heads/master@{#533164} OS: Windows (7,8,8.1,10) and Mac OS X(10.12.6,10.13.1,10.13.3) Pre-Condition:Enable 'RTL' Flag(Right-to-Left) form chrome://flags. Steps to reproduce: (1) Launch freshly installed chrome and navigate to gmail.com. (2) Login with valid credentials and observe. Actual Result: Password bubble does not appear in gmail.com after doing RTL . Expected Result: Password bubble should appear in gmail.com after doing RTL . This is a regression issue broken in ‘M-66’ and using per-revision bisect providing the bisect results, Good Build: 66.0.3334.0(Revision: 532208) Bad Build: 66.0.3335.0(Revision: 533164) You are probably looking for a change made after 533003 (known good), but no later than 533004 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/00c4d7d6f69574516058cf2fa3eb5c21ee267ba0..9a7a3991e35998df423168d6f550974d41944f72 Suspect:https://chromium.googlesource.com/chromium/src/+/9a7a3991e35998df423168d6f550974d41944f72 @mustaq@google.com: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note:Issue is not seen on Linux(14.04 LTS) OS. Thank You!
,
Feb 2 2018
,
Feb 2 2018
I can reproduce it on Linux and not in RTL. Seems like it's flaky. The reason isn't clear yet.
,
Feb 2 2018
From the log: Message: PasswordAutofillAgent::DidStartProvisionalLoad Message: Security origin cannot access password manager The password wasn't provisionally saved because the document URL is "about:blank".
,
Feb 2 2018
It's seems that r533004 is a culprit indeed. The new condition suppressed FireProbablyFormSubmitted() on gmail. When I click the button it triggers a provisional load of type PAGE_TRANSITION_LINK. It's wrong as I don't click a hyperlink. mustaq@, I suggest reverting the CL because apparently the new condition isn't precisely what we wanted.
,
Feb 2 2018
,
Feb 6 2018
Trying to understand why provisional load of type is affected by RTL. It shouldn't, and to me this points to a wrong assumption somewhere. I will investigate, and if a fix looks tricky, I will revert my CL. Could anyone please confirm which RTL flag affects this? I see three possible flags: chrome://flags/#force-ui-direction chrome://flags/#force-text-direction chrome://flags/#left-to-right-urls
,
Feb 6 2018
Oh this is not ever related to RTL settings!
,
Feb 6 2018
It's not relevant to RTL. I verified in the debugger that the new condition prevents one FireProbablyFormSubmitted event. It shouldn't happen because there is no click on a hyperlink.
,
Feb 7 2018
I was able to distinguish the gmail case from regular link-click-to-avoid-submit case. Please check if this sounds reasonable: https://chromium-review.googlesource.com/907072
,
Feb 8 2018
,
Feb 15 2018
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9825a2661470407eb2e6de514cf0d12edff59111 commit 9825a2661470407eb2e6de514cf0d12edff59111 Author: Mustaq Ahmed <mustaq@google.com> Date: Thu Feb 15 15:52:17 2018 Fix gmail login missing save password prompt. A fix for crbug.com/803193 caused a regression in "save password" prompt gmail. It turned out that we have been calling FireProbablyFormSubmitted() too many times even before that fix (e.g. used to be called during PAGE_TRANSITION_CLIENT_REDIRECT). Our previous fix didn't remove unnecessary calls and missed important cases of content-initiated navigation. This CL fires FireProbablyFormSubmitted() at the correct moment (only if DidStartProvisionalLoadduring is called at "content-initiated" navigation state) and when the navigation isn't triggered by a link-click. This satisfies all test cases as well as the gmail case. Bug: 807609 Change-Id: I741ea806445bb16d992641611ac7ecf8a8a95208 Reviewed-on: https://chromium-review.googlesource.com/907072 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#537029} [modify] https://crrev.com/9825a2661470407eb2e6de514cf0d12edff59111/components/autofill/content/renderer/form_tracker.cc
,
Feb 15 2018
,
Feb 16 2018
Rechecked the above issue on OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.4) with Canary chrome version:66.0.3349.0 and the issue works as intended. Kindly refer attached screen cast for reference. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by mustaq@chromium.org
, Feb 1 2018