New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807590 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 1
Type: Bug



Sign in to add a comment

cronet_unittests fails on BufferTest.TestInitWithHugeAllocFails

Project Member Reported by dgn@chromium.org, Jan 31 2018

Issue description

  [CRASH] BufferTest.TestInitWithHugeAllocFails:
  [ RUN      ] BufferTest.TestInitWithHugeAllocFails
  ==7102==WARNING: AddressSanitizer failed to allocate 0xd4a51000 bytes
  ==7102==AddressSanitizer's allocator is terminating the process instead of returning 0
  ==7102==If you don't like this behavior set allocator_may_return_null=1
  ==7102==AddressSanitizer CHECK failed: /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:225 "((0)) != (0)" (0x0, 0x0)
  
  [ CRASHED      ]
  Searching for native crashes in: /tmp/tmpYFnKtW
  Unknown Android release, consider passing --packed-lib.
  Reading Android symbols from: /b/build/slave/Android_Cronet_Builder_Asan/build/src
  Searching for Chrome symbols from within: /b/build/slave/Android_Cronet_Builder_Asan/build/src/out/Release/lib.unstripped:/b/build/slave/Android_Cronet_Builder_Asan/build/src/out/Release/lib:/b/build/slave/Android_Cronet_Builder_Asan/build/src/out/Release
  
  Stack Trace:
    RELADDR   FUNCTION   FILE:LINE
    4005b05d  <UNKNOWN>  /b/build/slave/Android_Cronet_Builder_Asan/build/src/ (/system/bin/app_process32
  [  FAILED  ] BufferTest.TestInitWithHugeAllocFails (CRASHED)


Sample failures:
- https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Builder%20Asan/builds/4667
- https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Builder%20Asan/builds/4673

Suspected CL:
https://chromium-review.googlesource.com/c/chromium/src/+/892401
 

Comment 1 by mef@chromium.org, Jan 31 2018

Cc: wangyix@chromium.org
Labels: OS-iOS
Owner: mef@chromium.org
This test is trying to allocate 1,000,000,000,000 bytes to verify that it fails predictably: https://cs.chromium.org/chromium/src/components/cronet/native/buffer_test.cc?l=72

I guess ASAN changes malloc to check on outrageously large allocations. 
I'll disable this test on ASAN configurations : https://chromium-review.googlesource.com/c/chromium/src/+/895722
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1df8ee7f1f3b13134e056ff1f4580ea2aa295ea

commit a1df8ee7f1f3b13134e056ff1f4580ea2aa295ea
Author: Misha Efimov <mef@google.com>
Date: Wed Jan 31 19:41:00 2018

[Cronet] Disable BufferTest.TestInitWithHugeAllocFails in ASAN builds.

Bug:  807590 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I197a38b994f029ee7b4e26e55f087e938dc7ead0
Reviewed-on: https://chromium-review.googlesource.com/895722
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533361}
[modify] https://crrev.com/a1df8ee7f1f3b13134e056ff1f4580ea2aa295ea/components/cronet/native/buffer_test.cc

Comment 3 by mef@chromium.org, Jan 31 2018

Status: Fixed (was: Assigned)

Sign in to add a comment