New issue
Advanced search Search tips

Issue 807576 link

Starred by 10 users
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Feb 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
ligim...@chromium.org
ccameron@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : [Mac] Page appears chopped after minimizing and maximizing chrome.

Reported by avsha...@etouch.net, Jan 31 2018 
Chrome Version : 66.0.3335.0 (Official Build) 94092b8f650d5552ed3595eb2b3a0a96488524e7-refs/heads/master@{#533164} 64-bit
OS : Mac Retina(10.12.6), Mac Touchbar (10.13.3)

What steps will reproduce the problem?
1. Freshly install chrome and launch it (By default user lands at chrome://welcome page).
2. In the same tab, type chrome://version in omnibox and hit ‘Enter’.
3. Now click on browser's ‘Minimize’ icon and maximize it again. 
4. Observe the Chrome://version page. (Kindly review an attached screen cast)

Actual Result : Page appears chopped after minimizing and maximizing chrome.

Expected Result : Page contents should not chop on minimizing and maximizing chrome.

This is a regression issue broken in ‘M-66’ and will soon update other details.
Actual_Result_Mac.mov
9.5 MB View Download

Comment 1 by avsha...@etouch.net, Jan 31 2018

Labels: hasbisect-per-revision RegressedIn-66 FoundIn-66 Target-66
Owner: ccameron@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue broken in ‘M-66’ and providing the bisect using ‘per-revision bisect’ script :
Good Build : 66.0.3334.0 (revision : 532208)
Bad Build : 66.0.3335.0 (revision : 533164)

You are probably looking for a change made after 532350 (known good), but no later than 532351 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/d78876f32ca7c1f40bd8add5665a9427dbbab950..5545b33782e2bc68548c0bdc12bc9ff6bc5e43e4

Suspect : https://chromium.googlesource.com/chromium/src/+/5545b33782e2bc68548c0bdc12bc9ff6bc5e43e4

@ccameron : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note : 
1. This issue is also observed at Chrome ’Manage People’ window and ‘Gmail’ inbox page.
2. Issue is reproducible on Mac Retina(10.12.6) and Mac Touch bar (10.13.3) machine.
3. Same issue is not reproducible on Mac(10.13.1), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS.
Expected_Result_Mac.mov
11.4 MB View Download

Comment 2 by schenney@chromium.org, Jan 31 2018

Components: -Blink>Paint Internals>Compositing

Comment 3 by ccameron@chromium.org, Feb 1 2018 

That's definitely the culprit CL.

Taking a look at it.

Comment 4 by ccameron@chromium.org, Feb 1 2018 

This is really bad ... it fails to repro in debug builds, trying a release.

Comment 5 by ccameron@chromium.org, Feb 1 2018 

Hmm, I can't reproduce this all on a release build either (but I hit it all the time on Canary).

I think this was fixed by r533183 -- verifying with local reverts.

Comment 6 by ccameron@chromium.org, Feb 1 2018 

Okay, who can spot the bug?

  delegated_frame_host_size_dip_ = size_dip;
  delegated_frame_host_size_pixels_ = gfx::ConvertSizeToPixel(
      delegated_frame_host_scale_factor_, delegated_frame_host_size_dip_);
  delegated_frame_host_scale_factor_ = scale_factor;

/facepalm

Comment 7 by nyerramilli@chromium.org, Feb 1 2018

Labels: ReleaseBlock-Stable
marking as RBS, please change if required.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/080aecf31b30e2e540f67bbf4e4c70f28bec8f9a

commit 080aecf31b30e2e540f67bbf4e4c70f28bec8f9a
Author: Christopher Cameron <ccameron@chromium.org>
Date: Thu Feb 01 04:21:56 2018

viz/mac: Fix pixel size calcuation

In this block
  size_dip_ = size_dip;
  size_pixels_ = gfx::ConvertSizeToPixel(scale_factor_, size_dip_);
  scale_factor_ = scale_factor;
We compute the DIP size using the old scale factor.

TBR=fsamuel

Bug:  807576 
Change-Id: Ib1b1f0496301cbd356c84ceec18b951150fe5468
Reviewed-on: https://chromium-review.googlesource.com/896968
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533555}
[modify] https://crrev.com/080aecf31b30e2e540f67bbf4e4c70f28bec8f9a/content/browser/renderer_host/browser_compositor_view_mac.mm

Comment 9 by fsam...@chromium.org, Feb 1 2018 

Doh, I missed this initial review too :S

Comment 10 by ccameron@chromium.org, Feb 1 2018

Cc: ccameron@chromium.org ligim...@chromium.org
 Issue 807855  has been merged into this issue.

Comment 11 by ccameron@chromium.org, Feb 1 2018

Status: Fixed (was: Assigned)

Comment 12 by nyerramilli@chromium.org, Feb 2 2018

Labels: ET-MUM-Reported

Comment 13 by ccameron@chromium.org, Feb 2 2018 

 Issue 807533  has been merged into this issue.

Comment 14 by ccameron@chromium.org, Feb 2 2018 

Issue 807626 has been merged into this issue.

Comment 15 by ccameron@chromium.org, Feb 2 2018 

 Issue 808530  has been merged into this issue.

Comment 16 by meh...@chromium.org, Feb 3 2018 

 Issue 808769  has been merged into this issue.

Comment 17 by meh...@chromium.org, Feb 3 2018 

 Issue 808674  has been merged into this issue.
►

Sign in to add a comment