New issue
Advanced search Search tips

Issue 807574 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 805426



Sign in to add a comment

Search query not reset if not completely cleared before search is closed

Project Member Reported by fhorschig@chromium.org, Jan 31 2018

Issue description

Chrome Version: 66
OS: Android

What steps will reproduce the problem?
(1) Enable #password-search flag at chrome://flags
(2) Navigate to Settings > Save Passwords
(3) Ensure the password list is not empty
(4) Click the search icon & enter any _non-empty_ query
(4) Navigate back

What is the expected result?
All settings (like the save toggle) should be brought back.

What happens instead?
The list is still filtered and other settings are hidden - as if the query wasn't reset.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/582aaa8638862661b3334d57af797078d0a93c77

commit 582aaa8638862661b3334d57af797078d0a93c77
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Wed Jan 31 16:14:04 2018

Restore save password preferences with aborted search

When the search view is collapsed, the search should be reset entirely.

Bug:  807574 ,  807306 
Change-Id: Id13eb9e119459d05751e06b515671eccacc776f2
Reviewed-on: https://chromium-review.googlesource.com/895485
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533289}
[modify] https://crrev.com/582aaa8638862661b3334d57af797078d0a93c77/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
[modify] https://crrev.com/582aaa8638862661b3334d57af797078d0a93c77/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java

Blocking: 805426
Status: Fixed (was: Started)

Sign in to add a comment