Issue metadata
Sign in to add a comment
|
Adaptive Toolbar: Have the fullscreen offset be adapted to the toolbar height change |
||||||||||||||||||||||
Issue descriptionFor now the fullscreen scrolling offset (i.e. the difference between the scrolling position where the fullscreen progress is 0 and the position where the progress is 1) is equal to the height of the toolbar. As the toolbar is no longer completely hidden in fullscreen, the scroll speed of the page is faster than the height reduction of the toolbar. Both should move at the same speed.
,
Mar 23 2018
,
Apr 5 2018
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d commit b7a0746e11f4b9d4aa6546dc14cb56b687fe968d Author: Gauthier Ambard <gambard@chromium.org> Date: Wed May 09 09:18:19 2018 Toolbar can have a non-zero height in fullscreen This CL allows the toolbar to have non-zero height in fullscreen. It can be used with the UI Refresh and the Browser Container being fullscreen. Bug: 807572 , 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If292c787596be8d543142cdf75c5b1d27eb66e4c Reviewed-on: https://chromium-review.googlesource.com/1030393 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#557130} [modify] https://crrev.com/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d/ios/chrome/browser/ui/toolbar/legacy_toolbar_ui_updater.h [modify] https://crrev.com/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d/ios/chrome/browser/ui/toolbar/legacy_toolbar_ui_updater.mm [modify] https://crrev.com/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d/ios/chrome/browser/ui/toolbar/legacy_toolbar_ui_updater_unittest.mm [modify] https://crrev.com/b7a0746e11f4b9d4aa6546dc14cb56b687fe968d/ios/chrome/browser/ui/toolbar/toolbar_owner.h
,
May 9 2018
,
May 9 2018
,
May 15 2018
Verified on chrome canary version 68.0.3431.0 on iPad pro and iPhone 8 plus with iOS 11.3.1 following steps mentioned in the duplicate bug Issue 824846 and performing testing around fullscreen. Webpage text is completely displayed in fullscreen mode. Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gambard@chromium.org
, Jan 31 2018