New issue
Advanced search Search tips

Issue 807565 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 736308



Sign in to add a comment

OOR-CORS: move from content/network to services/network

Project Member Reported by toyoshim@chromium.org, Jan 31 2018

Issue description

Move files under content/network/cors to services/network
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4b6d20277b8507137fff077a732aff34e69400f

commit d4b6d20277b8507137fff077a732aff34e69400f
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Feb 01 10:21:34 2018

OOR-CORS: move CORSURLLoader to services/network

This patch makes CORSURLLoader dependency-free from content/ and
move it to services/network.

To remove one of these dependency, I will introduce secure origin
whitelist in network::cors. This is needed to share the CORSURLLoader
implementation even if the network service is disabled, and will
be able to be removed once the network service is enabled by default.

Bug:  807565 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie0870b84c91f1c3132b52fd11cf21ae0a4b87e9a
Reviewed-on: https://chromium-review.googlesource.com/894969
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533623}
[modify] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/content/common/origin_util.cc
[modify] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/content/common/url_schemes.cc
[modify] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/content/network/BUILD.gn
[modify] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/content/network/DEPS
[modify] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/content/network/cors/cors_url_loader_factory.cc
[modify] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/content/network/cors/cors_url_loader_unittest.cc
[modify] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/content/public/common/origin_util.h
[modify] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/services/network/public/cpp/cors/cors.cc
[add] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/services/network/public/cpp/cors/cors_legacy.cc
[add] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/services/network/public/cpp/cors/cors_legacy.h
[rename] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/services/network/public/cpp/cors/cors_url_loader.cc
[rename] https://crrev.com/d4b6d20277b8507137fff077a732aff34e69400f/services/network/public/cpp/cors/cors_url_loader.h

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9507c7d790fcbb981d35e9d0a290f66576bd318a

commit 9507c7d790fcbb981d35e9d0a290f66576bd318a
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Fri Feb 02 10:09:17 2018

OOR-CORS: move CORSURLLoaderFactory to services/network

This patch moves CORSURLLoaderFactory and unit tests for
CORSURLLoader and CORSURLLoaderFactory to services/network.

Only Mechanical changes.

Since now that this patch remove the last source files in
content/network, this patch also removes content/network
directory completely. It affects WATCHLISTS, other BUILD.gn,
DEPS, and OWNERS files that refer content/network.

The patch also includes mechanical string replacements,
s/content\/network/services\/network/g.

Bug:  807565 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iba027a1c625d421e5671dd3faac5d32c1d2136ad
Tbr: jam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/895217
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534012}
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/WATCHLISTS
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/content/BUILD.gn
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/content/browser/BUILD.gn
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/content/browser/DEPS
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/content/browser/loader/resource_message_filter.cc
[delete] https://crrev.com/a01a779e04192eae55aa2d0a58cc3ccd32b650d1/content/network/BUILD.gn
[delete] https://crrev.com/a01a779e04192eae55aa2d0a58cc3ccd32b650d1/content/network/DEPS
[delete] https://crrev.com/a01a779e04192eae55aa2d0a58cc3ccd32b650d1/content/network/OWNERS
[delete] https://crrev.com/a01a779e04192eae55aa2d0a58cc3ccd32b650d1/content/network/cors/cors_url_loader_factory.cc
[delete] https://crrev.com/a01a779e04192eae55aa2d0a58cc3ccd32b650d1/content/network/cors/cors_url_loader_factory.h
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/content/public/common/OWNERS
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/content/test/BUILD.gn
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/services/network/BUILD.gn
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/services/network/PRESUBMIT.py
[rename] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/services/network/cors_url_loader_unittest.cc
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/services/network/public/cpp/BUILD.gn
[add] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/services/network/public/cpp/cors/cors_url_loader_factory.cc
[add] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/services/network/public/cpp/cors/cors_url_loader_factory.h
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/services/network/public/interfaces/network_service.mojom
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/services/proxy_resolver/OWNERS
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
[modify] https://crrev.com/9507c7d790fcbb981d35e9d0a290f66576bd318a/tools/perf/contrib/network_service/OWNERS

Status: Fixed (was: Started)

Sign in to add a comment