Back button in the tablet mode does nothing for Chrome apps (Files app and media players) |
|||||||
Issue descriptionWhat steps will reproduce the problem? 1. Switch to the tablet mode 2. Open Chrome 3. Open Files app (or some other Chrome app) 4. Click on the back button at the bottom left corner What is the expected result? Go back to Chrome What happens instead of that? Nothing happens Please provide any additional information below. Attach a screenshot if possible. fukino@, could you take a look?
,
Jan 31 2018
,
Jan 31 2018
Issue 806672 has been merged into this issue.
,
Jan 31 2018
,
Feb 15 2018
For builtin apps like Files app, Gallery app, etc..., they can respond to the Back button by listening BrowserBack event. Modifying built-in apps to close/minimize on Back button is doable and it sounds a reasonable short-term solution for M66. That said, it should be better to make sure that Android app, Chrome apps, and Chrome browser have consistent behavior on back button by default. To discuss the general behavior those application types, I filed issue 812564.
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6ce6ea425adc8aa4072fb6439c32ff41fe905b8 commit e6ce6ea425adc8aa4072fb6439c32ff41fe905b8 Author: Naoki Fukino <fukino@chromium.org> Date: Wed Feb 28 10:08:04 2018 Files app: Handle BrowserBack to minimize the app window. Android apps are closed by BrowserBack key on Chrome OS. To make the built-in app's behavior consistent and keep the app alive, we minimize the app window on BrowserBack. Bug: 807521 Test: Manually tested Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib4883b75791721baf1b2ff814d4e5047a0dfe726 Reviewed-on: https://chromium-review.googlesource.com/940743 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#539774} [modify] https://crrev.com/e6ce6ea425adc8aa4072fb6439c32ff41fe905b8/ui/file_manager/file_manager/foreground/js/file_manager_commands.js [modify] https://crrev.com/e6ce6ea425adc8aa4072fb6439c32ff41fe905b8/ui/file_manager/file_manager/main.html
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa165f6035455612e158396b25cd4cfcfb145695 commit fa165f6035455612e158396b25cd4cfcfb145695 Author: Naoki Fukino <fukino@chromium.org> Date: Wed Feb 28 16:03:05 2018 Handle BrowserBack to close the window in built-in media players. Android apps are closed by BrowserBack key on Chrome OS. To make the built-in app's behavior consistent and keep the app alive, we close the built-in media players on BrowserBack. Bug: 807521 Test: Manually tested. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic5097216bc83f6fd78db6f7d9155b0705b2eea3b Reviewed-on: https://chromium-review.googlesource.com/940784 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#539836} [modify] https://crrev.com/fa165f6035455612e158396b25cd4cfcfb145695/ui/file_manager/audio_player/elements/audio_player.js [modify] https://crrev.com/fa165f6035455612e158396b25cd4cfcfb145695/ui/file_manager/audio_player/js/audio_player.js [modify] https://crrev.com/fa165f6035455612e158396b25cd4cfcfb145695/ui/file_manager/gallery/js/gallery.js [modify] https://crrev.com/fa165f6035455612e158396b25cd4cfcfb145695/ui/file_manager/video_player/js/video_player.js
,
Apr 9 2018
,
Apr 9 2018
,
Apr 9 2018
,
Apr 9 2018
,
Apr 11 2018
Let me close this bug by reducing the scope to Files app and media player apps. For the back button issue with other apps (Keep, Text, Secure Shell), issue 812564 was filed separately. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by satorux@chromium.org
, Jan 31 2018