New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807517 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Container-overflow in views::Textfield::UpdateAfterChange

Project Member Reported by ClusterFuzz, Jan 31 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5859030304817152

Fuzzer: cdiehl_dharma
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: Container-overflow READ 8
Crash Address: 0x6030003b32a0
Crash State:
  views::Textfield::UpdateAfterChange
  views::Textfield::ConfirmCompositionText
  ui::InputMethodChromeOS::OnWillChangeFocusedClient
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_chromeos&range=533005:533006

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5859030304817152

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 31 2018

Labels: Test-Predator-Auto-Owner
Owner: gayane@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/1f35e553f7c6e49b2a93037dc5a596af173ee7b7 (Remove WebRTC-SystemUDPSendSocketSize study).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 2 by sheriffbot@chromium.org, Jan 31 2018

Labels: M-65
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 31 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 31 2018

Labels: Pri-1
The change list identified does not directly have anything to do with the codepath that crashed. The open  Issue 786534  looks quite similar with a different stack and regression range.
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 1 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Components: Internals>Views
Labels: -M-65 M-66
Project Member

Comment 9 by sheriffbot@chromium.org, Feb 14 2018

gayane: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: sergeyu@chromium.org
sergeyu@ I don't think the change is related. Could you also have a look?
I don't have access to the clusterfuzz report. I can't access  crbug.com/786534  either. From what I see here the problem doesn't seem to be related to the change that removed WebRTC experiment.
I cannot access the bug you mentioned either, but I was able to see the clusterfuzz report with my chromium account
Cc: gayane@chromium.org
Owner: sammiequon@chromium.org
Looks like an issue in ash window selector, sammiequon@, can you please take a look.
crash repro steps

1. Open 1 window at least.
2. Enter overview (F5).
3. Press Ctrl+Alt+U.
4. Close all windows.
sammiequon@: Are you actively working on this? It is a security regression, and a stable blocker.
Re #15 https://chromium-review.googlesource.com/c/chromium/src/+/932547 just sent to CQ, that should fix this
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e8ca713db9ff36b42f288d5af043a2703449c0a

commit 5e8ca713db9ff36b42f288d5af043a2703449c0a
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Mar 02 22:35:07 2018

overview: Fix crash when exit after using Ctrl Shift U.

We should instead prevent Ctrl Shift U mode in overview somehow, but this
will stop the crash in the meantime.

Test: ash_unittests WindowSelectorTest.ExitInUnderlineMode
Bug:  807517 
Change-Id: Ie7d889937c110583454a281a318b682f62cd6084
Reviewed-on: https://chromium-review.googlesource.com/932547
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540664}
[modify] https://crrev.com/5e8ca713db9ff36b42f288d5af043a2703449c0a/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/5e8ca713db9ff36b42f288d5af043a2703449c0a/ash/wm/overview/window_selector_unittest.cc

Status: Fixed (was: Assigned)
Project Member

Comment 19 by sheriffbot@chromium.org, Mar 7 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 20 by sheriffbot@chromium.org, Mar 16 2018

Labels: Merge-Request-66
Project Member

Comment 21 by sheriffbot@chromium.org, Mar 16 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: josa...@chromium.org
+josafat for merge approval
Labels: -Merge-Review-66 Merge-Approved-66
Approved. Branch:3359
Labels: -reward-topanel reward-0
Also found by internal fuzzers during the 48 hour window, I'm afraid.
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 19 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36da9721f559a62fc6a02224c168e5b31a639886

commit 36da9721f559a62fc6a02224c168e5b31a639886
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Mar 19 22:12:11 2018

[merge to 66] overview: Fix crash when exit after using Ctrl Shift U.

We should instead prevent Ctrl Shift U mode in overview somehow, but this
will stop the crash in the meantime.

TBR=sammiequon@google.com

(cherry picked from commit 5e8ca713db9ff36b42f288d5af043a2703449c0a)

Test: ash_unittests WindowSelectorTest.ExitInUnderlineMode
Bug:  807517 
Change-Id: Ie7d889937c110583454a281a318b682f62cd6084
Reviewed-on: https://chromium-review.googlesource.com/932547
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540664}
Reviewed-on: https://chromium-review.googlesource.com/969641
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#328}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/36da9721f559a62fc6a02224c168e5b31a639886/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/36da9721f559a62fc6a02224c168e5b31a639886/ash/wm/overview/window_selector_unittest.cc

Labels: -ReleaseBlock-Stable
Project Member

Comment 27 by sheriffbot@chromium.org, Jun 13 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment