New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807501 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Cache bigquery api client

Project Member Reported by wylieb@chromium.org, Jan 31 2018

Issue description

Right now the client from bigquery_helper is created every time a call is made, cache this client so it's only constructed once.
 

Comment 1 by wylieb@chromium.org, Feb 22 2018

Owner: wylieb@chromium.org
Status: Assigned (was: Available)

Comment 2 by wylieb@chromium.org, Apr 20 2018

Owner: ----
Status: Available (was: Assigned)
Owner: liaoyuke@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bc52ad839536b6cae8bbb8b2459c6fff6105b555

commit bc52ad839536b6cae8bbb8b2459c6fff6105b555
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu May 31 21:16:11 2018

[Findit] Refactoring bigquery helper.

This CL refactors the biquery helper to cache the client, cleans up
stale comments and correctly deals with job incomplete errors.

Bug:  807501 
Change-Id: I7bc3b80b0610d38d6d34f7fbadb6ad91735c9dc6
Reviewed-on: https://chromium-review.googlesource.com/1079609
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/bc52ad839536b6cae8bbb8b2459c6fff6105b555/appengine/findit/services/test/bigquery_helper_test.py
[modify] https://crrev.com/bc52ad839536b6cae8bbb8b2459c6fff6105b555/appengine/findit/services/bigquery_helper.py

Status: Fixed (was: Started)

Sign in to add a comment