New issue
Advanced search Search tips

Issue 807497 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Out-of-flow boxes should not be children of anonymous flex items

Project Member Reported by futhark@chromium.org, Jan 31 2018

Issue description

We currently insert absolute positioned siblings of text node children of flex boxes into the anonymous flex item wrapper for the text node(s). That is not correct.

Tests:

external/wpt/css/css-flexbox/anonymous-flex-item-004.html
external/wpt/css/css-flexbox/anonymous-flex-item-005.html

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36dde5a6c1998b823bf8cda836ba27979db0e725

commit 36dde5a6c1998b823bf8cda836ba27979db0e725
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu Feb 01 22:09:18 2018

Don't put out-of-flow boxes in anonymous flex/grid items.

A single anonymous flex/grid item should just contain a contiguous
sequence of text runs.

TEST=external/wpt/css/css-flexbox/anonymous-flex-item-004.html

Bug: 807497
Change-Id: If995a5ac107210083fd13de9c6983b91b4ef3fa3
Reviewed-on: https://chromium-review.googlesource.com/895844
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533825}
[modify] https://crrev.com/36dde5a6c1998b823bf8cda836ba27979db0e725/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/36dde5a6c1998b823bf8cda836ba27979db0e725/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/grid-items/anonymous-grid-item-001.html
[modify] https://crrev.com/36dde5a6c1998b823bf8cda836ba27979db0e725/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Sign in to add a comment