Issue metadata
Sign in to add a comment
|
Missing "Share this Network with other users" checkbox for password protected networks |
||||||||||||||||||||||
Issue descriptionChrome Version: <From about:version: Google Chrome 10323.9.0> Chrome OS Version: <From about:version: Platform 65.0.3325.0> Chrome OS Platform: <Eve,Candy> Network info: <WiFi> Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1) Login as Owner and connect to an password protected network Note: This is also an issue on OOBE screen. Expected Result: When entering the password, There should be an checkbox to share the network with other users of the device. Actual Result: Checkbox is missing in the new UI. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always. What is the impact to the user, and is there a workaround? If so, what is it? Networks cannot be shared among the users. Please provide any additional information below. Attach a screen shot or log if possible. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jan 31 2018
Does the network already exist (i.e. is it listed in Settings > Wi-Fi > Known networks)? If so, this is expected behavior as the sharing state of a known network can not be changed. (The old UI showed the toggle but it was disabled). Assuming it is a new network, can you test this with a more recent version (>= 65.0.3325.9) ? There were a number of fixes to the UI there and it seems to work OK for me here.
,
Jan 31 2018
,
Jan 31 2018
,
Jan 31 2018
I did some testing and there are definitely a couple of bugs. The logic should be:
* New WiFi network configurations ('Add other...') should always show the toggle.
* Unconfigured networks (i.e. never connected) should always show the toggle.
* In OOBE / login the toggle should be 'on' and disabled (all networks configured in the login screen will be shared since no user is logged in).
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7416c74afceb8d81f119a69833a5ec81a7ea980 commit f7416c74afceb8d81f119a69833a5ec81a7ea980 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Feb 01 19:08:30 2018 Network config: fix shared logic This fixes a couple of issues with the 'shared' logic in the config UI: * 'guid' != configured, use source != CrOnc.Source.NONE instead * Share toggle should be visible for all unconfigured networks, even if it can not be changed (i.e. in the login screen). Bug: 807494 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6f068adbe04b9011763426e9b9f72ac0ebb01535 Reviewed-on: https://chromium-review.googlesource.com/896023 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533761} [modify] https://crrev.com/f7416c74afceb8d81f119a69833a5ec81a7ea980/chrome/test/data/webui/cr_components/network_config_test.js [modify] https://crrev.com/f7416c74afceb8d81f119a69833a5ec81a7ea980/ui/webui/resources/cr_components/chromeos/network/network_config.html [modify] https://crrev.com/f7416c74afceb8d81f119a69833a5ec81a7ea980/ui/webui/resources/cr_components/chromeos/network/network_config.js
,
Feb 1 2018
Does the network already exist (i.e. is it listed in Settings > Wi-Fi > Known networks)? If so, this is expected behavior as the sharing state of a known network can not be changed. (The old UI showed the toggle but it was disabled). >> Nope this is new network. Assuming it is a new network, can you test this with a more recent version (>= 65.0.3325.9) ? There were a number of fixes to the UI there and it seems to work OK for me here. >> ok will check and report back.
,
Feb 1 2018
,
Feb 2 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/598dcb3f9cee507e1588b4a73b38cb50829ac7d4 commit 598dcb3f9cee507e1588b4a73b38cb50829ac7d4 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Feb 05 19:55:50 2018 Network config: fix shared logic This fixes a couple of issues with the 'shared' logic in the config UI: * 'guid' != configured, use source != CrOnc.Source.NONE instead * Share toggle should be visible for all unconfigured networks, even if it can not be changed (i.e. in the login screen). TBR=stevenjb@chromium.org (cherry picked from commit f7416c74afceb8d81f119a69833a5ec81a7ea980) Bug: 807494 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6f068adbe04b9011763426e9b9f72ac0ebb01535 Reviewed-on: https://chromium-review.googlesource.com/896023 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#533761} Reviewed-on: https://chromium-review.googlesource.com/902424 Cr-Commit-Position: refs/branch-heads/3325@{#312} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/598dcb3f9cee507e1588b4a73b38cb50829ac7d4/chrome/test/data/webui/cr_components/network_config_test.js [modify] https://crrev.com/598dcb3f9cee507e1588b4a73b38cb50829ac7d4/ui/webui/resources/cr_components/chromeos/network/network_config.html [modify] https://crrev.com/598dcb3f9cee507e1588b4a73b38cb50829ac7d4/ui/webui/resources/cr_components/chromeos/network/network_config.js
,
Feb 5 2018
,
Mar 3 2018
Eve M-66 10451.0.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aashuto...@chromium.org
, Jan 31 2018308 KB
308 KB View Download
89.1 KB
89.1 KB View Download