New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807493 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tree status needs better text overflow

Project Member Reported by dpa...@chromium.org, Jan 31 2018

Issue description

When the tree is closed the tree status can be a very long string. See tree_status_before.png where text is overflowing outside of the viewport.

See suggestion of better overflow at tree_status_after.png.

In order to achieve this need to add the following:

overflow: hidden;
word-break: break-word;

at https://cs.chromium.org/chromium/infra/go/src/go.chromium.org/luci/milo/frontend/appengine/static/common/css/console.css?l=53-62.
 
tree_status_before.png
41.4 KB View Download
tree_status_after.png
66.7 KB View Download
Components: -Infra>Platform>Buildbot Infra>Platform>Milo
Labels: LUCI-Backlog
Status: Available (was: Untriaged)
This now manifests itself in MILO (since it's now UI for buildbot)
Cc: no...@chromium.org mknyszek@chromium.org hinoka@chromium.org
+cc'ing a few people: next time one of you is working in the milo code would you mind making this 2 line change? Thanks!

Comment 3 by efoo@chromium.org, Feb 28 2018

Status: Assigned (was: Available)

Comment 4 by efoo@chromium.org, Feb 28 2018

Labels: -LUCI-Backlog LUCI-Chromium LUCI-KnownIssues-UI
Owner: efoo@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/0d435eac8a3c31bb8ac7505316388e610a34ee81

commit 0d435eac8a3c31bb8ac7505316388e610a34ee81
Author: Eric Foo <efoo@chromium.org>
Date: Thu Mar 01 00:25:20 2018

Add overflow and word-break in CSS so Tree Status look better

Bug:  807493 
Change-Id: Ia3f0f09f7da511e2504f83e396a7c9bb30dd5a7b
Reviewed-on: https://chromium-review.googlesource.com/941987
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>

[modify] https://crrev.com/0d435eac8a3c31bb8ac7505316388e610a34ee81/milo/frontend/appengine/static/common/css/console.css

Comment 6 by efoo@chromium.org, Mar 1 2018

Status: Fixed (was: Assigned)

Sign in to add a comment