New issue
Advanced search Search tips

Issue 807475 link

Starred by 2 users
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Feb 2018
Cc:
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 738611



Sign in to add a comment

Polymer: Migrate paper-input to its latest (2.1.0) version.

Project Member Reported by dpa...@chromium.org, Jan 31 2018 
This is necessary to unblock migration to Polymer 2. My existing attempt at [1] has triggered a bunch of a11y errors, see [2] (also pasting below.

PDFExtensionTest.Basic
MediaRouterElementsBrowserTest.MediaRouterContainerSearchPart1
SettingsAccessibilityTest.MANAGE_PROFILE_aria_valid_attr_value
MediaRouterElementsBrowserTest.MediaRouterContainerSearchPart2
SettingsAccessibilityTest.MANAGE_PROFILE_tabindex
MediaRouterElementsBrowserTest.MediaRouterContainerFilterPart2
MediaRouterElementsBrowserTest.MediaRouterContainerFilterPart1

After consulting with hcarmona, these seem to be false positives, and those tests need to be updated.


[1] https://chromium-review.googlesource.com/c/chromium/src/+/892299
[2] https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/634922

Comment 1 by dpa...@chromium.org, Jan 31 2018

Blocking: 738611

Comment 2 by hcarmona@chromium.org, Jan 31 2018

Owner: hcarmona@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2f3b1c3b5117c20f313a135059723366a6e488c

commit f2f3b1c3b5117c20f313a135059723366a6e488c
Author: Hector Carmona <hcarmona@chromium.org>
Date: Wed Jan 31 20:29:10 2018

WebUI: Fix a11y test failures caused by paper-input 2.1.0

- Update a11y exceptions
- Disable old-style tests

See crrev.com/c/892299 for paper-input update.

Bug:  807475 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I77bd1857166c297f985a2c9c8a202b5148a30cf8
Reviewed-on: https://chromium-review.googlesource.com/894889
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533384}
[modify] https://crrev.com/f2f3b1c3b5117c20f313a135059723366a6e488c/chrome/test/data/webui/media_router/media_router_elements_browsertest.js
[modify] https://crrev.com/f2f3b1c3b5117c20f313a135059723366a6e488c/chrome/test/data/webui/settings/a11y/manage_profile_a11y_test.js
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c032cc3b21942356cd0e7bc4cdd392cded098fb1

commit c032cc3b21942356cd0e7bc4cdd392cded098fb1
Author: Hector Carmona <hcarmona@chromium.org>
Date: Fri Feb 02 01:34:22 2018

WebUI: Add slot to children of paper-input-container b/c Polymer v2.

CL adds slot="<appropriate slot>" to all users of paper-input container who are using polymer from:
chrome://resources/polymer/v1_0/paper-input/paper-input-container.html

R=dpapad@chromium.org

Bug:  807475 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I15d7e7d7c24776855e99c8764a296357e459d235
Reviewed-on: https://chromium-review.googlesource.com/898268
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533901}
[modify] https://crrev.com/c032cc3b21942356cd0e7bc4cdd392cded098fb1/chrome/browser/resources/chromeos/login/gaia_input.html
[modify] https://crrev.com/c032cc3b21942356cd0e7bc4cdd392cded098fb1/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html
[modify] https://crrev.com/c032cc3b21942356cd0e7bc4cdd392cded098fb1/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
[modify] https://crrev.com/c032cc3b21942356cd0e7bc4cdd392cded098fb1/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/c032cc3b21942356cd0e7bc4cdd392cded098fb1/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/c032cc3b21942356cd0e7bc4cdd392cded098fb1/ui/webui/resources/cr_components/chromeos/network/network_config_input.html
[modify] https://crrev.com/c032cc3b21942356cd0e7bc4cdd392cded098fb1/ui/webui/resources/cr_components/chromeos/network/network_nameservers.html
[modify] https://crrev.com/c032cc3b21942356cd0e7bc4cdd392cded098fb1/ui/webui/resources/cr_components/chromeos/network/network_property_list.html
[modify] https://crrev.com/c032cc3b21942356cd0e7bc4cdd392cded098fb1/ui/webui/resources/cr_components/chromeos/network/network_proxy.html
[modify] https://crrev.com/c032cc3b21942356cd0e7bc4cdd392cded098fb1/ui/webui/resources/cr_components/chromeos/network/network_proxy_input.html
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4653a995c9f44ea82e9eeb366deeeaa696eddee

commit c4653a995c9f44ea82e9eeb366deeeaa696eddee
Author: Hector Carmona <hcarmona@chromium.org>
Date: Fri Feb 02 22:22:26 2018

WebUI: Fix a11y test failures caused by paper-input 2.1.0

- Update a11y exceptions in edit_dictionary_a11y_test.js
- Delete unused copy of edit_dictionary_a11y_test.js

R=dpapad@chromium.org

Bug:  807475 
Change-Id: Id3b166b1e253c90d697e3b6752d48fefa52e717e
Reviewed-on: https://chromium-review.googlesource.com/898488
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534171}
[modify] https://crrev.com/c4653a995c9f44ea82e9eeb366deeeaa696eddee/chrome/test/data/webui/settings/a11y/edit_dictionary_a11y_test.js
[modify] https://crrev.com/c4653a995c9f44ea82e9eeb366deeeaa696eddee/chrome/test/data/webui/settings/a11y/manage_profile_a11y_test.js
[delete] https://crrev.com/3dc27da6720d0103fc28934670832a5771513309/chrome/test/data/webui/settings/edit_dictionary_a11y_test.js
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbf4d6cce495d5797ffde3fdd04006b3e4000e39

commit dbf4d6cce495d5797ffde3fdd04006b3e4000e39
Author: Hector Carmona <hcarmona@chromium.org>
Date: Wed Feb 14 22:02:10 2018

WebUI: Update Polymer paper-input version 1.1.21 -> 2.1.0.

In addition to the paper-input update this CL will:
 - Fix mis-styled components
 - Address TODOs that should be taken care of by update

R=dpapad@chromium.org

Bug: 738611,  807475 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6cc1bdd22ea23e48f0c37db60bb5eb6163b0a55c
Reviewed-on: https://chromium-review.googlesource.com/902898
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536836}
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/chrome/browser/resources/chromeos/login/gaia_input.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/chromium.patch
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/bower.json
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-addon-behavior-extracted.js
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container-extracted.js
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-error.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-extracted.js
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-input.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea-extracted.js
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/dbf4d6cce495d5797ffde3fdd04006b3e4000e39/ui/file_manager/gallery/gallery.html

Comment 7 by hcarmona@chromium.org, Feb 16 2018

Status: Fixed (was: Started)
►

Sign in to add a comment