ArcAccessibilityHelperBridgeBrowserTest.PreferenceChange crashes in viz::HostFrameSinkManager::CreateCompositorFrameSinkSupport() |
|||||||
Issue descriptionFailing on the mojo FYI bot. Not sure when it started, more than 1 week and 200 builds ago. https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20ChromiumOS/?limit=200 [ RUN ] ArcAccessibilityHelperBridgeBrowserTest.PreferenceChange [11118:11118:0130/072840.174929:WARNING:chrome_browser_main_chromeos.cc(597)] Running as stub user with profile dir: test-user [11118:11137:0130/072840.706165:ERROR:logging_chrome.cc(218)] Unable to create symlink /b/s/w/it2BXv9X/.org.chromium.Chromium.hfh1Rk/dUwQQoR/test-user/chrome_debug.log pointing at /b/s/w/it2BXv9X/.org.chromium.Chromium.hfh1Rk/dUwQQoR/test-user/chrome_debug_20180130-072840: No such file or directory (2) [11118:11118:0130/072840.752746:WARNING:user_session_manager.cc(1050)] Attempting to save user password for non enterprise user. [11118:11118:0130/072840.819494:ERROR:delegated_frame_host.cc(232)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool) [11118:11118:0130/072840.908573:ERROR:wallpaper_controller.cc(1228)] User is ephemeral or guest! Fallback to default wallpaper. [11118:11118:0130/072840.950352:FATAL:host_frame_sink_manager.cc(225)] Check failed: frame_sink_manager_impl_. #0 0x000003e89d8c base::debug::StackTrace::StackTrace() #1 0x000003ea3f9c logging::LogMessage::~LogMessage() #2 0x000005fa0591 viz::HostFrameSinkManager::CreateCompositorFrameSinkSupport() #3 0x000005f68a04 aura::LayerTreeFrameSinkLocal::BindToClient() #4 0x00000304420d exo::SurfaceTreeHost::SurfaceTreeHost() #5 0x000003039012 exo::ShellSurfaceBase::ShellSurfaceBase() #6 0x00000303774e exo::ShellSurface::ShellSurface() #7 0x000001c6b9ee exo::test::ExoTestWindow::ExoTestWindow() #8 0x000001c6bc16 exo::test::ExoTestHelper::CreateWindow() #9 0x000001391d2f arc::ArcAccessibilityHelperBridgeBrowserTest_PreferenceChange_Test::RunTestOnMainThread() #10 0x0000044cfb85 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #11 0x000003fbd999 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #12 0x000003fbc72d ChromeBrowserMainParts::PreMainMessageLoopRun() #13 0x000001983328 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #14 0x000002731f61 content::BrowserMainLoop::PreMainMessageLoopRun() #15 0x000002b69d15 content::StartupTaskRunner::RunAllTasksNow() #16 0x00000273030d content::BrowserMainLoop::CreateStartupTasks() #17 0x000002734e73 content::BrowserMainRunnerImpl::Initialize() #18 0x00000272dee2 content::BrowserMain() #19 0x000003e56f02 content::ContentMainRunnerImpl::Run() #20 0x0000060fc03b service_manager::Main() #21 0x000003e554e4 content::ContentMain() #22 0x0000044cf7ef content::BrowserTestBase::SetUp() #23 0x000003f7563c InProcessBrowserTest::SetUp() #24 0x000001d02871 testing::Test::Run() I'm going to filter it out to make the bot green.
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77c436b90aec1062d2b9aad01ba0ba9294edb8a1 commit 77c436b90aec1062d2b9aad01ba0ba9294edb8a1 Author: James Cook <jamescook@chromium.org> Date: Wed Jan 31 15:13:28 2018 viz: Disable ArcAccessibilityHelperBridgeBrowserTest.PreferenceChange Disable it in viz_browser_tests via filter file so we can get the Mojo FYI bot green. it's been failing for > 1 week and > 200 builds. Bug: 807465 Change-Id: I4f067303cc74d607d519fd7f72b20d5b75d92c28 Reviewed-on: https://chromium-review.googlesource.com/894634 Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#533272} [modify] https://crrev.com/77c436b90aec1062d2b9aad01ba0ba9294edb8a1/testing/buildbot/filters/viz.browser_tests.filter
,
Mar 12 2018
Arc is currently not supported by Viz. WindowPort needs to be updated to provide a ClientLayerTreeFrameSink
,
Mar 12 2018
+penghuang@ FYI as the ExoTestHelper has exposed this error The stack trace in #1 is still valid. As discussed in triage I'm assigning to kylechar@ as comment #3 documents what needs to happen. This is not blocking finch trial as it it CrOS only.
,
Mar 15 2018
No work is needed here until we start on Chrome OS.
,
Jun 19 2018
,
Jun 19 2018
https://chromium-review.googlesource.com/c/chromium/src/+/1104799 moved the tests to a different target, and now apparently the filter doesn't seem to apply anymore. I can't find the mistake though, the proper filter file does seem to be listed in all the new places.
,
Jun 19 2018
Hm, testing/buildbot/test_suite_exceptions.pyl sets '--test-launcher-filter-file=../../testing/buildbot/filters/browser_tests_cros_asan.filter', maybe that overrides the filter set for viz_browser_tests? For now, I'll try adding an entry to browser_tests_cros_asan.filter to get the bot green again, though that's probably not the right thing to do...
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15cac61103d31f983840fff882b24c2e837e6383 commit 15cac61103d31f983840fff882b24c2e837e6383 Author: Marc Treib <treib@chromium.org> Date: Tue Jun 19 10:24:10 2018 Disable ArcAccessibilityHelperBridgeBrowserTest.PreferenceChange on CrOS ASan TBR=thakis@chromium.org NOTRY=true Bug: 807465 Change-Id: I217899e452758bd531eb800b3ed8ae761f8af4d7 Reviewed-on: https://chromium-review.googlesource.com/1105826 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568392} [modify] https://crrev.com/15cac61103d31f983840fff882b24c2e837e6383/testing/buildbot/filters/browser_tests_cros_asan.filter
,
Jun 19 2018
(deduped)
,
Jun 19 2018
Taking out of the sheriff queue since bug 854120 is tracking the ongoing problem.
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22ad976643568040b1e99613fcc5065ce79acd5e commit 22ad976643568040b1e99613fcc5065ce79acd5e Author: kylechar <kylechar@chromium.org> Date: Tue Jun 19 15:25:08 2018 Remove CrOS ASan filter files. The tests disabled by these filters are disabled by DISABLE_ macro, don't exist or are disabled in a different filter file already. Bug: 807465 , 854120 Change-Id: I6c7a854c266fa2099b55098857973e0e5640981d Reviewed-on: https://chromium-review.googlesource.com/1104967 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#568456} [modify] https://crrev.com/22ad976643568040b1e99613fcc5065ce79acd5e/chrome/test/BUILD.gn [modify] https://crrev.com/22ad976643568040b1e99613fcc5065ce79acd5e/testing/buildbot/chromium.memory.json [modify] https://crrev.com/22ad976643568040b1e99613fcc5065ce79acd5e/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/11d4958ce6ed7da6eb5cb07cf95583cf87bf4707/testing/buildbot/filters/browser_tests_cros_asan.filter [delete] https://crrev.com/11d4958ce6ed7da6eb5cb07cf95583cf87bf4707/testing/buildbot/filters/unit_tests_cros_asan.filter [modify] https://crrev.com/22ad976643568040b1e99613fcc5065ce79acd5e/testing/buildbot/test_suite_exceptions.pyl
,
Jun 19 2018
I removed browser_tests_cros_asan.filter so ASan viz_browser_tests should use viz.browser_tests.filter again.
,
Jun 21 2018
Reproduced today ahead of triage
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/660c41bfc304cc2169068f22a49cd53fd4b6dd3c commit 660c41bfc304cc2169068f22a49cd53fd4b6dd3c Author: jonross <jonross@chromium.org> Date: Thu Jul 26 22:05:59 2018 Disable ArcAccessibilityHelperBridgeBrowserTest on Viz Currently when using VizDisplayCompositor, Arc doesn't work. There's ongoing work for Exo+Viz which is needed to enable it. Until then I'm adding an early exit to ArcAccessibilityHelperBridgeBrowserTest so that we can get ride of the filter files associated with viz_browser_tests TEST=ArcAccessibilityHelperBridgeBrowserTest Bug: 807465 Change-Id: Iae350792c4fcedd23561e524cc7d269c50846e5e Reviewed-on: https://chromium-review.googlesource.com/1151760 Reviewed-by: Peng Huang <penghuang@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#578456} [modify] https://crrev.com/660c41bfc304cc2169068f22a49cd53fd4b6dd3c/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
,
Aug 31
Recent Arc+Exo work has this working again on Viz, re-enabling
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf83dc59c5cba01cd6203926fa7dacfb3051299a commit cf83dc59c5cba01cd6203926fa7dacfb3051299a Author: jonross <jonross@chromium.org> Date: Fri Aug 31 16:54:13 2018 Re-enable ArcAccessibilityHelperBridgeBrowserTest.PreferenceChange on Viz Exo+Viz has been fixed, this test now passes. So I'm removing the early exit for when running it with VizDisplayCompositor TEST=ArcAccessibilityHelperBridgeBrowserTest.PreferenceChange TBR=dtseng@chromium.org Bug: 807465 Change-Id: Ie6c56a4b1b0091fc56e19ba6eac91b672c141628 Reviewed-on: https://chromium-review.googlesource.com/1199594 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#588062} [modify] https://crrev.com/cf83dc59c5cba01cd6203926fa7dacfb3051299a/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
,
Aug 31
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kylec...@chromium.org
, Jan 31 2018